💲[Native Checkout] Pledge button cell reuse bugfix #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifbarrera
reviewed
Aug 9, 2019
| @@ -89,12 +89,14 @@ public final class RewardCardContainerView: UIView { | |||
| self.viewModel.outputs.pledgeButtonHidden.observeValues { [weak self] hidden in | |||
| guard let self = self else { return } | |||
|
|
|||
| self.pledgeButton.isHidden = hidden | |||
There was a problem hiding this comment.
Can we use the reactive binding for this? self.pledgeButton.rac.hidden = self.viewModel.outputs.pledgeButtonHidden
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Fixed a minor issue from #779 in that the pledge button sometimes appears on a recycled cell.
🤔 Why
We don't want to see a strange empty button on a reward cell.
🛠 How
For the hiding and showing of the button we were activating and deactivating constraints to allow the card view to stretch all the way to the bottom of the cell. In addition to this we also need to hide the button in case it was previously visible on the cell before being recycled.
👀 See
Trello, screenshots, external resources?
✅ Acceptance criteria
View your pledgebutton, keep scrolling and there shouldn't be any other cells containing and empty button as in the screenshot.