Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-627] "View rewards" when a project has ended #979

Merged
merged 3 commits into from Dec 6, 2019

Conversation

ifbarrera
Copy link
Contributor

📲 What

Adds "View rewards" as a menu option on the Manage/View Pledge screen when a project has ended.

🤔 Why

So that users can still view all the reward tiers on a project they backed that has ended.

🛠 How

  • added the logic to return the .viewRewards option in the menu when the project has ended
  • updated the logic that displays the button on the rewards carousel: it used to read "View your pledge", but now because we're coming from the View Pledge screen, it just reads "Selected"
  • updated tests and screenshots

👀 See

KIZcdVZIGi

♿️ Accessibility

N/A

🏎 Performance

N/A

✅ Acceptance criteria

  • Navigate to a project you backed that has ended. Tap "View Pledge" from the project page. On the Manage Pledge screen, tap the Menu icon on the top right. You should see "View rewards" and "Contact creator" as options. Tap "View rewards". You should be taken to the rewards carousel - all rewards that were not backed should have no CTA button, while the reward that was backed should have a CTA button that is disabled and reads "Selected".

Copy link
Contributor

@Scollaco Scollaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid ⭐️

@ifbarrera ifbarrera merged commit f6e3ac3 into master Dec 6, 2019
@ifbarrera ifbarrera deleted the NT-627-view-rewards-project-ended branch December 6, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants