Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code style updates #410

Merged
merged 13 commits into from Mar 6, 2019

Conversation

Projects
None yet
2 participants
@grzuy
Copy link
Collaborator

commented Mar 2, 2019

Continue what started in #330 and #338

grzuy added some commits Mar 1, 2019

@grzuy

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 3, 2019

@lmansur Would be great to have your feedback on this if you have any time.
Thank you! :-)

@lmansur

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

Thanks for the ping, @grzuy.

The PR looks good to me 👍. I think we are in the right path of establishing a Rubocop file and committing to it.

Do you think it's worth setting up some kind of static code analysis (CodeClimate, Codacy, HoundCI, etc) as a PR check? It might be a good way of ensuring we don't have regressions on the code style.

@grzuy

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 6, 2019

Thanks for the feedback!

We do check for code style regressions on every PR already. TravisCI fails if rubocop fails since 1e9d601. :-)

@grzuy grzuy merged commit 935b918 into kickstarter:master Mar 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@grzuy grzuy deleted the grzuy:style branch Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.