Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify time range formatting. #54

Closed
wants to merge 1 commit into from
Closed

Unify time range formatting. #54

wants to merge 1 commit into from

Conversation

zaks
Copy link

@zaks zaks commented Oct 2, 2019

The standard in https://orgmode.org/manual/Timestamps.html is
<start_time>--<end_time>.

The standard in https://orgmode.org/manual/Timestamps.html is
<start_time>--<end_time>.
@telotortium
Copy link
Collaborator

Hi, I'll take a look at this this weekend. I'd like to implement some unit tests first (see #46).

@zaks
Copy link
Author

zaks commented Oct 7, 2019

Sure thing. Thanks Robert.

@telotortium
Copy link
Collaborator

Hi, I'm reluctant to make this change. The reason is, when I schedule an entry with a
compact time range, the agenda shows me both the scheduled and the finish times on one line. However, when I schedule the same entry with a
full time range, an extra line is added.

@zaks
Copy link
Author

zaks commented Nov 7, 2019

Hi Robert,

Sorry for the silence. I somehow missed the email notification.

org-gcal does not generate Scheduled entries. The format in the file is as following:

:org-gcal:
<2019-11-22 Fri 00:00>--<2019-11-25 Mon 00:00>

This shows within agenda just once.

What do you think?

Cheers, Slawek

@telotortium
Copy link
Collaborator

Hi @zaks, I've been a bit remiss at updating the documentation (see #40). However, in #34 I modified the code to update the SCHEDULED property instead of inserting the timestamp into the :org-gcal: drawer if SCHEDULED is present, so that I can reschedule events easily using normal org-mode commands. It appears that using SCHEDULED does cause 2 lines to appear in the agenda, as I showed above. This is why I'm reluctant to merge this, especially because maintaining the two separate formats is not much more work in the code (for example, org-element will automatically parse both of them).

@zaks zaks closed this May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants