Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Set of small fixes for code quality #348

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Member

manstis commented Jun 19, 2014

Your formatting appears wrong.

See
https://github.com/selrahal/drools/blob/d2cf3e14f8c4ac0bda5413463d759b17f84d9122/drools-examples/src/main/java/org/drools/games/adventures/AdventureFrame.java#L663
as an example.

Please familiarize yourself with the code formatting in README.md.

On 19 June 2014 21:43, selrahal notifications@github.com wrote:

See https://issues.jboss.org/browse/DROOLS-506

You can merge this Pull Request by running

git pull https://github.com/selrahal/drools examplesCleanup

Or view, comment on, or merge it at:

droolsjbpm#348
Commit Summary

  • Set of small fixes for code quality

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
droolsjbpm#348.

manstis, I cleaned up the commit.

Member

mariofusco commented Sep 23, 2014

I merged all the improvements you suggested except for the serialVersionUIDs that I find totally useless in this context.

@mariofusco mariofusco closed this Sep 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment