Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHBMS-4312] Loading pasword from a keystore #1273

Merged
merged 3 commits into from Nov 24, 2017

Conversation

rstancel
Copy link
Contributor

Jira: https://issues.jboss.org/browse/RHBPMS-4312

Added loading password from a keystore also from other methods

@@ -60,6 +60,14 @@
<groupId>com.thoughtworks.xstream</groupId>
<artifactId>xstream</artifactId>
</dependency>
<dependency>
<groupId>org.kie.server</groupId>
<artifactId>kie-server-services-common</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this dependency needed? From code changes it looks like kie-server-common should be enough.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Fixed

Copy link
Contributor

@mswiderski mswiderski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, @sutaakar any further comments?

Copy link
Contributor

@sutaakar sutaakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rstancel
Copy link
Contributor Author

Jenkins retest this

@mswiderski
Copy link
Contributor

@rstancel this now has conflicts, could you please resolve

@mswiderski mswiderski merged commit dc71956 into kiegroup:master Nov 24, 2017
mswiderski pushed a commit that referenced this pull request Nov 27, 2017
…#1281)

* [RHBMS-4312] Loading pasword from a keystore

* [RHBMS-4312] Loading pasword from a keystore enhanced for possibility to read multiple passwords

* [RHBMS-4312] Loading pasword from a keystore (#1273)

* [RHBMS-4312] Loading pasword from a keystore

* [RHBMS-4312] Loading pasword from a keystore

* [RHBMS-4312] Loading pasword from a keystore enhanced for possibility to read multiple passwords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants