New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHBMS-4312] Loading pasword from a keystore #1273
Conversation
| @@ -60,6 +60,14 @@ | |||
| <groupId>com.thoughtworks.xstream</groupId> | |||
| <artifactId>xstream</artifactId> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.kie.server</groupId> | |||
| <artifactId>kie-server-services-common</artifactId> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this dependency needed? From code changes it looks like kie-server-common should be enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. Fixed
9f9e6c1
to
b6f07e8
Compare
b6f07e8
to
440df90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, @sutaakar any further comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
55d64a0
to
440df90
Compare
|
Jenkins retest this |
|
@rstancel this now has conflicts, could you please resolve |
…#1281) * [RHBMS-4312] Loading pasword from a keystore * [RHBMS-4312] Loading pasword from a keystore enhanced for possibility to read multiple passwords * [RHBMS-4312] Loading pasword from a keystore (#1273) * [RHBMS-4312] Loading pasword from a keystore * [RHBMS-4312] Loading pasword from a keystore * [RHBMS-4312] Loading pasword from a keystore enhanced for possibility to read multiple passwords
Jira: https://issues.jboss.org/browse/RHBPMS-4312
Added loading password from a keystore also from other methods