New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JBPM-9714] Include sort column to advance queries variables API #2506
Conversation
1e2d18a
to
838429d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
backward incompatible.
unrelated, jenkins retest this |
|
327405c
to
a0957f3
Compare
Jenkins retest this please |
"ignore": [ { | ||
"code": "java.method.numberOfParametersChanged", | ||
"old": "method javax.ws.rs.core.Response org.kie.server.remote.rest.jbpm.RuntimeDataResource::queryProcessesByVariables(javax.ws.rs.core.HttpHeaders, java.lang.String, java.lang.Integer, java.lang.Integer)", | ||
"new": "method javax.ws.rs.core.Response org.kie.server.remote.rest.jbpm.RuntimeDataResource::queryProcessesByVariables(javax.ws.rs.core.HttpHeaders, java.lang.String, java.lang.Integer, java.lang.Integer, java.lang.String, boolean)", | ||
"package": "org.kie.server.remote.rest.jbpm", | ||
"classSimpleName": "RuntimeDataResource", | ||
"methodName": "queryProcessesByVariables", | ||
"elementKind": "method", | ||
"justification": "https://issues.redhat.com/browse/JBPM-9714" | ||
}, | ||
{ | ||
"code": "java.method.numberOfParametersChanged", | ||
"old": "method javax.ws.rs.core.Response org.kie.server.remote.rest.jbpm.RuntimeDataResource::queryUserTasksByVariables(javax.ws.rs.core.HttpHeaders, java.lang.String, java.lang.Integer, java.lang.Integer)", | ||
"new": "method javax.ws.rs.core.Response org.kie.server.remote.rest.jbpm.RuntimeDataResource::queryUserTasksByVariables(javax.ws.rs.core.HttpHeaders, java.lang.String, java.lang.Integer, java.lang.Integer, java.lang.String, boolean)", | ||
"package": "org.kie.server.remote.rest.jbpm", | ||
"classSimpleName": "RuntimeDataResource", | ||
"methodName": "queryUserTasksByVariables", | ||
"elementKind": "method", | ||
"justification": "https://issues.redhat.com/browse/JBPM-9714" | ||
}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should not be needed anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elguardian Note that the class is RuntimeDataResource, that can be modified without breaking backward compatibility because is the annotated REST resource class, and I hope no one is directly invoking it (doing it will be a mistake). I guess the revapi is there to make sure that nobody changes the resource accidentally. The two parameters added are optional query params.
Jenkins retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, awesome work @fjtirado !
Jenkins retest thise please |
Kudos, SonarCloud Quality Gate passed! |
JIRA:
link
referenced Pull Requests:
kiegroup/jbpm#1950