Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBPM-9714] Include sort column to advance queries variables API #2506

Merged
merged 1 commit into from Jun 21, 2021

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Jun 10, 2021

JIRA:

link

referenced Pull Requests:
kiegroup/jbpm#1950

Copy link
Member

@elguardian elguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backward incompatible.

@fjtirado
Copy link
Contributor Author

unrelated, jenkins retest this

@fjtirado
Copy link
Contributor Author

backward incompatible.
where?

@fjtirado fjtirado force-pushed the JBPM-9714 branch 3 times, most recently from 327405c to a0957f3 Compare June 14, 2021 09:22
@fjtirado fjtirado requested a review from elguardian June 14, 2021 09:22
@elguardian
Copy link
Member

Jenkins retest this please

Comment on lines +31 to +50
"ignore": [ {
"code": "java.method.numberOfParametersChanged",
"old": "method javax.ws.rs.core.Response org.kie.server.remote.rest.jbpm.RuntimeDataResource::queryProcessesByVariables(javax.ws.rs.core.HttpHeaders, java.lang.String, java.lang.Integer, java.lang.Integer)",
"new": "method javax.ws.rs.core.Response org.kie.server.remote.rest.jbpm.RuntimeDataResource::queryProcessesByVariables(javax.ws.rs.core.HttpHeaders, java.lang.String, java.lang.Integer, java.lang.Integer, java.lang.String, boolean)",
"package": "org.kie.server.remote.rest.jbpm",
"classSimpleName": "RuntimeDataResource",
"methodName": "queryProcessesByVariables",
"elementKind": "method",
"justification": "https://issues.redhat.com/browse/JBPM-9714"
},
{
"code": "java.method.numberOfParametersChanged",
"old": "method javax.ws.rs.core.Response org.kie.server.remote.rest.jbpm.RuntimeDataResource::queryUserTasksByVariables(javax.ws.rs.core.HttpHeaders, java.lang.String, java.lang.Integer, java.lang.Integer)",
"new": "method javax.ws.rs.core.Response org.kie.server.remote.rest.jbpm.RuntimeDataResource::queryUserTasksByVariables(javax.ws.rs.core.HttpHeaders, java.lang.String, java.lang.Integer, java.lang.Integer, java.lang.String, boolean)",
"package": "org.kie.server.remote.rest.jbpm",
"classSimpleName": "RuntimeDataResource",
"methodName": "queryUserTasksByVariables",
"elementKind": "method",
"justification": "https://issues.redhat.com/browse/JBPM-9714"
}]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be needed anymore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elguardian Note that the class is RuntimeDataResource, that can be modified without breaking backward compatibility because is the annotated REST resource class, and I hope no one is directly invoking it (doing it will be a mistake). I guess the revapi is there to make sure that nobody changes the resource accidentally. The two parameters added are optional query params.

@fjtirado fjtirado requested a review from elguardian June 15, 2021 14:59
@elguardian
Copy link
Member

Jenkins retest this please

Copy link
Member

@elguardian elguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, awesome work @fjtirado !

@elguardian
Copy link
Member

Jenkins retest thise please

@sonarcloud
Copy link

sonarcloud bot commented Jun 18, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@elguardian elguardian merged commit 6db0a92 into kiegroup:master Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants