Guvnor assembly descriptor for JBoss AS 7 #20

Merged
merged 1 commit into from Sep 20, 2011

Conversation

Projects
None yet
2 participants
@matnil
Contributor

matnil commented Sep 20, 2011

I noticed Guvnor was missing a WAR for JBoss AS 7 so I created an assembly descriptor. Hope you find this useful. I have tested the WAR on JBoss AS 7.0.1.Final in standalone mode.

Regards,
Mattias Nilsson Grip

@matnil

This comment has been minimized.

Show comment
Hide comment
@matnil

matnil Sep 20, 2011

Owner

Added Guvnor assembly descriptor for JBoss AS 7.

Owner

matnil commented on 3f388ee Sep 20, 2011

Added Guvnor assembly descriptor for JBoss AS 7.

This comment has been minimized.

Show comment
Hide comment
@ge0ffrey

ge0ffrey Sep 20, 2011

I am going to merge this and test it. If it works, it will be part of 5.3.0.CR1.
Afterwards, I 'll try to find a better way of doing the execution manifest magic.
For example, we could create a modules.xml in src/main/assembly/guvnor-jboss-as-7_0/WEB-INF/modules.xml which might be able to do the same thing as the manifest

I am going to merge this and test it. If it works, it will be part of 5.3.0.CR1.
Afterwards, I 'll try to find a better way of doing the execution manifest magic.
For example, we could create a modules.xml in src/main/assembly/guvnor-jboss-as-7_0/WEB-INF/modules.xml which might be able to do the same thing as the manifest

@ge0ffrey

This comment has been minimized.

Show comment
Hide comment
@ge0ffrey

ge0ffrey Sep 20, 2011

Great stuff!

Can we avoid the need for extra execution magic by doing this in the assembly xml file itself?

Great stuff!

Can we avoid the need for extra execution magic by doing this in the assembly xml file itself?

This comment has been minimized.

Show comment
Hide comment
@matnil

matnil Sep 20, 2011

Owner

I found no way of adding this manifest entry directly in the assembly descriptor. But I'm not a Maven expert so maybe it can be done. I agree that having duplicate executions of assembly plugin is not so nice...

Owner

matnil replied Sep 20, 2011

I found no way of adding this manifest entry directly in the assembly descriptor. But I'm not a Maven expert so maybe it can be done. I agree that having duplicate executions of assembly plugin is not so nice...

This comment has been minimized.

Show comment
Hide comment
@ge0ffrey

ge0ffrey Sep 20, 2011

jboss-deployment-structure.xml might be a way, but that's only a secondary priority at this time. If we can get guvnor to work for jboss as 7 that's great.

Here's the issue: https://issues.jboss.org/browse/GUVNOR-1575
There are still some problems, but I am looking into them.

If we can get this to work, I 'll create a blog and give you a big thank you in it :)
If you want to talk real-time, join us on #drools on irc.codehaus.org

jboss-deployment-structure.xml might be a way, but that's only a secondary priority at this time. If we can get guvnor to work for jboss as 7 that's great.

Here's the issue: https://issues.jboss.org/browse/GUVNOR-1575
There are still some problems, but I am looking into them.

If we can get this to work, I 'll create a blog and give you a big thank you in it :)
If you want to talk real-time, join us on #drools on irc.codehaus.org

ge0ffrey pushed a commit that referenced this pull request Sep 20, 2011

Geoffrey De Smet
Merge pull request #20 from matnil/guvnorJBoss7
Guvnor assembly descriptor for JBoss AS 7 (still needs testing, but if testing works, it will be part of 5.3.0.CR1)

@ge0ffrey ge0ffrey merged commit 41c8f55 into kiegroup:master Sep 20, 2011

@ge0ffrey

This comment has been minimized.

Show comment
Hide comment
@ge0ffrey

ge0ffrey Sep 21, 2011

Member

Based on this pull request I've found out that the root issue why guvnor doesn't work on jboss as 7 was the version of cxf.
https://issues.jboss.org/browse/GUVNOR-1575
After fixing that, I 've managed to simplify it to no special build tricks and just 1 war for jboss 7 (both web and non-web).
Thanks a lot for this pull request. Check the blog for a public thank you later today :)

Member

ge0ffrey commented Sep 21, 2011

Based on this pull request I've found out that the root issue why guvnor doesn't work on jboss as 7 was the version of cxf.
https://issues.jboss.org/browse/GUVNOR-1575
After fixing that, I 've managed to simplify it to no special build tricks and just 1 war for jboss 7 (both web and non-web).
Thanks a lot for this pull request. Check the blog for a public thank you later today :)

@matnil

This comment has been minimized.

Show comment
Hide comment
@matnil

matnil Sep 21, 2011

Contributor

Ok, that's great! I'm glad the pull request was to some help.

----- Ursprungligt meddelande -----
Från: "Geoffrey De Smet" reply@reply.github.com
Till: "Mattias Nilsson Grip" mattias.nilsson.grip@redpill-linpro.com
Skickat: onsdag, 21 sep 2011 11:54:57
Ämne: Re: [guvnor] Guvnor assembly descriptor for JBoss AS 7 (#20)

Based on this pull request I've found out that the root issue why guvnor doesn't work on jboss as 7 was the version of cxf.
https://issues.jboss.org/browse/GUVNOR-1575
After fixing that, I 've managed to simplify it to no special build tricks and just 1 war for jboss 7 (both web and non-web).
Thanks a lot for this pull request. Check the blog for a public thank you later today :)

Reply to this email directly or view it on GitHub:
droolsjbpm#20 (comment)

Contributor

matnil commented Sep 21, 2011

Ok, that's great! I'm glad the pull request was to some help.

----- Ursprungligt meddelande -----
Från: "Geoffrey De Smet" reply@reply.github.com
Till: "Mattias Nilsson Grip" mattias.nilsson.grip@redpill-linpro.com
Skickat: onsdag, 21 sep 2011 11:54:57
Ämne: Re: [guvnor] Guvnor assembly descriptor for JBoss AS 7 (#20)

Based on this pull request I've found out that the root issue why guvnor doesn't work on jboss as 7 was the version of cxf.
https://issues.jboss.org/browse/GUVNOR-1575
After fixing that, I 've managed to simplify it to no special build tricks and just 1 war for jboss 7 (both web and non-web).
Thanks a lot for this pull request. Check the blog for a public thank you later today :)

Reply to this email directly or view it on GitHub:
droolsjbpm#20 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment