From 85ce29770a9b12de8c404a4517574b8ed3b240ae Mon Sep 17 00:00:00 2001 From: Alexandre Porcelli Date: Wed, 14 Jan 2015 06:35:12 -0500 Subject: [PATCH] BZ-1175682: a bad fix for BZ-1122594, blocked any user that had 'user' or 'manager' roles --- .../security/KieFileSystemAuthorizationManager.java | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/kie-wb-common-services/kie-wb-common-services-backend/src/main/java/org/kie/workbench/common/services/backend/security/KieFileSystemAuthorizationManager.java b/kie-wb-common-services/kie-wb-common-services-backend/src/main/java/org/kie/workbench/common/services/backend/security/KieFileSystemAuthorizationManager.java index 6a8e1b2809a..d1d1b9f9b8d 100644 --- a/kie-wb-common-services/kie-wb-common-services-backend/src/main/java/org/kie/workbench/common/services/backend/security/KieFileSystemAuthorizationManager.java +++ b/kie-wb-common-services/kie-wb-common-services-backend/src/main/java/org/kie/workbench/common/services/backend/security/KieFileSystemAuthorizationManager.java @@ -23,11 +23,10 @@ public boolean authorize( final Resource resource, } private boolean checkRole( final User subject ) { - if ( subject.getRoles().contains( new RoleImpl( USER.toString() ) ) || subject.getRoles().contains( new RoleImpl( MANAGER.toString() ) ) ) { - if ( subject.getRoles().contains( new RoleImpl( ADMIN.toString() ) ) || subject.getRoles().contains( new RoleImpl( DEVELOPER.toString() ) ) || - subject.getRoles().contains( new RoleImpl( ANALYST.toString() ) ) ) { - return true; - } + if ( subject.getRoles().contains( new RoleImpl( ADMIN.toString() ) ) || + subject.getRoles().contains( new RoleImpl( DEVELOPER.toString() ) ) || + subject.getRoles().contains( new RoleImpl( ANALYST.toString() ) ) ) { + return true; } return false; }