DROOLS-2913: [DMN Designer] Data-types: Grid: FunctionDefinition #2055
Conversation
| protected Consumer<HasName> clearDisplayNameConsumer() { | ||
| return (hn) -> { | ||
| final CompositeCommand.Builder commandBuilder = newHasNameHasNoValueCommand(hn); | ||
| getUpdateStunnerTitleCommand("").ifPresent(commandBuilder::addCommand); |
There was a problem hiding this comment.
I think that I already saw something pretty similar on InvocationGrid, LiteralExpression, and BaseExpressionGrid. Maybe we could try to avoid the duplication, but if the refactoring represents a big indirection, I'm ok for keeping it as is.
There was a problem hiding this comment.
@karreiro Let me loop back to this type of thing when all the current PRs are merged (i.e. I'll collect all these types of comment and probably do a "clean up" JIRA afterwards). Thank-you.
There was a problem hiding this comment.
@karreiro ... and yes, this standard override of the default implementation is re-used in the places you say... but not everywhere; only overrides in a few places (but the override is the same each time, so room for improvement).
There was a problem hiding this comment.
@manstis ok. Thank you for clarifying 😊
There was a problem hiding this comment.
|
@jomarko This PR is good to review too now; thanks. |
|
@jomarko can you please take a look on this? |
| final Text typeRef = context.getRenderer().getTheme().getHeaderText(); | ||
| typeRef.setFontStyle(FONT_STYLE_TYPE_REF); | ||
| typeRef.setFontSize(BaseExpressionGridTheme.FONT_SIZE - 2.0); | ||
| typeRef.setText("(" + headerMetaData.getTypeRef().toString() + ")"); |
There was a problem hiding this comment.
I think this can be shortened to:
typeRef.setText("(" + headerMetaData.getTypeRef() + ")");
|
@manstis manual check passed, please just say your opinion to my comment above before approving. |
|
Jenkins please retest this. |
1 similar comment
|
Jenkins please retest this. |
See https://issues.jboss.org/browse/DROOLS-2913
As with all these "in grid" editor changes; this PR will be merged after the others in the queue.