search highlight #452

Open
kdurant opened this Issue Jul 29, 2013 · 10 comments

Projects

None yet

4 participants

@kdurant
kdurant commented Jul 29, 2013

if I let ctrlp window at the top of the screen, I can not know what character I enter according to highlight.
So I hope ctrlp can only highlight the input characters, like sublime

@kien
Owner
kien commented Jul 29, 2013

You mean you want it to highlight only the individual characters, not the entire matched string? This won't be simple since the matching is done with match() which only returns the first position.

@kdurant
kdurant commented Jul 29, 2013

yes, I look forward to that moment

@aaronjensen

I implemented this for ctrlp-cmatcher: https://github.com/JazzCore/ctrlp-cmatcher/pull/8/files

Let me know if it looks good @kien and I can pull request it here too.

wemux 1 tch - vim 2013-10-08 20-40-56

@kien
Owner
kien commented Oct 9, 2013

It certainly does. Please go ahead with the pull request.
Thanks!

@aaronjensen

@kien should I be able to use echom to print messages for debugging from ctrlp? They don't seem to end up in :messages. Is there some other trick to log what's going on?

@kien
Owner
kien commented Oct 9, 2013

@aaronjensen some main functions in ctrlp are called with sil! to make it a bit more invisible/unobtrusive. So you may have to track down and remove a few of those instances for the messages to appear.

@aaronjensen

thanks, that was helpful. one other question, do you want me to follow the style of shortening every keyword to its shortest possible? personally I find it incredibly hard to read, but I don't want to break existing style...

@kien
Owner
kien commented Oct 10, 2013

No, don't worry about that just yet.

@alexandnpu

When will the code merge be done? @aaronjensen 's fix is very useful.

@aaronjensen

@alexandnpu you can follow along in the pull request: #488

I have to clean it up some and kien is going to take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment