Improved highlighting #488

Open
wants to merge 3 commits into
from

Conversation

Projects
None yet
9 participants
@aaronjensen

Two options here for highlighting, see the two different commits. The second is better than the first, but more complicated.

@kien

This comment has been minimized.

Show comment
Hide comment
@kien

kien Oct 10, 2013

Owner

Thank you! I'll check it out as soon as I can. It may be in a while, though, since I've been incredibly busy lately.

Owner

kien commented Oct 10, 2013

Thank you! I'll check it out as soon as I can. It may be in a while, though, since I've been incredibly busy lately.

@aaronjensen aaronjensen referenced this pull request Oct 11, 2013

Open

search highlight #452

aaronjensen added some commits Oct 11, 2013

More complicated, but even better highlighting
Prefers grouping words together, examples:

app/assets/javascripts/common
---                    ------
> app/common

app/models/group_user.rb
--- ------       ----
> appmodelsuser
@aaronjensen

This comment has been minimized.

Show comment
Hide comment
@aaronjensen

aaronjensen Oct 11, 2013

@kdurant

This comment has been minimized.

Show comment
Hide comment
@kdurant

kdurant Oct 15, 2013

@kien why not accept this pull request?

kdurant commented Oct 15, 2013

@kien why not accept this pull request?

@kien

This comment has been minimized.

Show comment
Hide comment
@kien

kien Oct 15, 2013

Owner

@kdurant I haven't been able to check it out yet. Plus it's still a work-in-progress.

Owner

kien commented Oct 15, 2013

@kdurant I haven't been able to check it out yet. Plus it's still a work-in-progress.

@aaronjensen

This comment has been minimized.

Show comment
Hide comment
@aaronjensen

aaronjensen Oct 15, 2013

I wouldn't call it a work in progress anymore unless there is anything you'd like me to change. It seems to work. I'm using a similar thing w/ https://github.com/JazzCore/ctrlp-cmatcher and it's working great.

I wouldn't call it a work in progress anymore unless there is anything you'd like me to change. It seems to work. I'm using a similar thing w/ https://github.com/JazzCore/ctrlp-cmatcher and it's working great.

@dsawardekar dsawardekar referenced this pull request in dsawardekar/ember.vim Oct 30, 2013

Closed

ctrlp window does not highlight match #2

@tommcdo

This comment has been minimized.

Show comment
Hide comment
@tommcdo

tommcdo Nov 18, 2013

+1

Would love to see this merged.

tommcdo commented Nov 18, 2013

+1

Would love to see this merged.

@drn

This comment has been minimized.

Show comment
Hide comment
@drn

drn Dec 18, 2013

+1 Would love to see this merged as well

drn commented Dec 18, 2013

+1 Would love to see this merged as well

@positron

This comment has been minimized.

Show comment
Hide comment
@positron

positron Dec 19, 2013

+1

+1

@rgrinberg

This comment has been minimized.

Show comment
Hide comment
@rgrinberg

rgrinberg Apr 17, 2014

Contributor

+1

Contributor

rgrinberg commented Apr 17, 2014

+1

@adelarsq

This comment has been minimized.

Show comment
Hide comment
@adelarsq

adelarsq Apr 29, 2014

+1

+1

@d11wtq d11wtq referenced this pull request in ctrlpvim/ctrlp.vim Aug 8, 2014

Merged

Improve highlighting #4

@d11wtq

This comment has been minimized.

Show comment
Hide comment
@d11wtq

d11wtq Aug 8, 2014

Moved to: ctrlpvim#4

d11wtq commented Aug 8, 2014

Moved to: ctrlpvim#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment