forked from com-lihaoyi/Ammonite
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scalapy completion dev #2
Open
kiendang
wants to merge
18
commits into
scalapy-completion
Choose a base branch
from
scalapy-completion-dev
base: scalapy-completion
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
take this out when submitting PR to upstream
02e7bb7
to
88b47d0
Compare
25c6297
to
bf9cbe3
Compare
f5fc081
to
f862e11
Compare
93a15dd
to
982fe51
Compare
fc591dc
to
d15b958
Compare
d15b958
to
821e11e
Compare
6eebb6a
to
ba20148
Compare
4399b90
to
ea91986
Compare
ea91986
to
d73158e
Compare
a4ab7e7
to
d8420f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds completion support for ScalaPy in ammonite. It is not to be merged into ammonite as is but ideally waits till ammonite has support for completion extension
How to try this out
build an executable from this branch
./mill "amm[2.13.6].assembly"
run ammonite
inside the repl, set up ScalaPy
Features
Basic completion is provided by the standard library rlcompleter, more advanced completion is available if jedi is installed.
Basic completion
This provides completion for attributes only
Things like
py.Dynamic.global.range(10).cou|
won't workJedi completion
This has support for more advanced completion thanks to
jedi
static analysis