Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

When the accessibility frame is not set, use the view frame #140

Merged
merged 2 commits into from Dec 7, 2012

Conversation

Projects
None yet
3 participants

matvore commented Aug 2, 2012

On the iOS Simulator 5.0, there are times when the Accessibility Inspector will
determine the accessibility frame correctly but the accessibilityFrame property
on the element will be {0, 0, 0, 0}. This happens in some cases when the UI is
created programmatically.

As a work-around when running on 5.0 and prior, this change attempts to
duplicate the OS's behavior of guessing the accessibility frame. It assumes
{0, 0, WIDTH, HEIGHT} where WIDTH and HEIGHT are equal to view.frame.width and
view.frame.height.

@matvore matvore When the accessibility frame is not set, use the view frame
On the iOS Simulator 5.0, there are times when the Accessibility Inspector will
determine the accessibility frame correctly but the accessibilityFrame property
on the element will be {0, 0, 0, 0}. This happens in some cases when the UI is
created programmatically.

As a work-around when running on 5.0 and prior, this change attempts to
duplicate the OS's behavior of guessing the accessibility frame. It assumes
{0, 0, WIDTH, HEIGHT} where WIDTH and HEIGHT are equal to view.frame.width and
view.frame.height.
36ff983
Contributor

efirestone commented Aug 15, 2012

A couple small style nits, but otherwise looks good. Also, please sign our contributor's license agreement: https://spreadsheets.google.com/spreadsheet/viewform?formkey=dDViT2xzUHAwRkI3X3k5Z0lQM091OGc6MQ&ndplr=1

matvore commented Aug 17, 2012

Thank you for the tips, I have applied them. Do you have a corporate version of the license agreement? I am advised by my employer that we must sign a corporate agreement before I contribute.

matvore commented Aug 22, 2012

I signed the agreement and my last commit has your suggestions applied, please take a look.
Thanks!

@puls puls added a commit that referenced this pull request Dec 7, 2012

@puls puls Merge pull request #140 from matvore/fallback-to-view-frame-if-access…
…-frame-is-not-set

When the accessibility frame is not set, use the view frame
14f731a

@puls puls merged commit 14f731a into kif-framework:master Dec 7, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment