Automatically enable accessibility on the device also #93

Merged
merged 2 commits into from Nov 15, 2011

Conversation

Projects
None yet
2 participants
@sgleadow
Contributor

sgleadow commented Nov 15, 2011

My previous pull request for enabling accessibility on the device. After some comments on my blog post about it, I modified the code to also run on the device. I wrote up my findings on another blog post

Without this code, when I run KIF on a device without VoiceOver on, the accessibility values are not available to KIF and the test fails. With this code, the values become available automatically and the tests can run on the device.

@puls

This comment has been minimized.

Show comment
Hide comment
@puls

puls Nov 15, 2011

Contributor

Awesome, but I'd change the name of the method from _enableAccessibilityInSimulator to something more general.

Contributor

puls commented Nov 15, 2011

Awesome, but I'd change the name of the method from _enableAccessibilityInSimulator to something more general.

@sgleadow

This comment has been minimized.

Show comment
Hide comment
@sgleadow

sgleadow Nov 15, 2011

Contributor

Good catch, I missed that completely. I have renamed the method to be general

Contributor

sgleadow commented Nov 15, 2011

Good catch, I missed that completely. I have renamed the method to be general

puls added a commit that referenced this pull request Nov 15, 2011

Merge pull request #93 from sgleadow/enable-accessibility-on-device
Automatically enable accessibility on the device also

@puls puls merged commit 87b535b into kif-framework:master Nov 15, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment