Added logic to avoid layer shifts causing a layer to be stuck on #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@haata It looks like the Travis CI failures are unrelated to my changes -- it's failing in a brew install. |
|
Thanks @ntietz. I just fixed (I hope) the travis and appveyor builds. Still trying to get the hang of them. The change looks good. I'm going to wait until the builds re-run, then I'll merge (I want to see if I can update master, then restart failed builds on PRs). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #66 and resolves that issue. Now, I cannot use layer shifts to cause a layer to be stuck on.