diff --git a/.pylintrc b/.pylintrc new file mode 100644 index 000000000..6311c4618 --- /dev/null +++ b/.pylintrc @@ -0,0 +1,582 @@ +[MASTER] + +# A comma-separated list of package or module names from where C extensions may +# be loaded. Extensions are loading into the active Python interpreter and may +# run arbitrary code. +extension-pkg-whitelist= + +# Add files or directories to the blacklist. They should be base names, not +# paths. +ignore=CVS + +# Add files or directories matching the regex patterns to the blacklist. The +# regex matches against base names, not paths. +ignore-patterns= + +# Python code to execute, usually for sys.path manipulation such as +# pygtk.require(). +init-hook='import sys; sys.path.append(".")' + +# Use multiple processes to speed up Pylint. Specifying 0 will auto-detect the +# number of processors available to use. +jobs=1 + +# Control the amount of potential inferred values when inferring a single +# object. This can help the performance when dealing with large functions or +# complex, nested conditions. +limit-inference-results=100 + +# List of plugins (as comma separated values of python module names) to load, +# usually to register additional checkers. +load-plugins= + +# Pickle collected data for later comparisons. +persistent=yes + +# Specify a configuration file. +#rcfile= + +# When enabled, pylint would attempt to guess common misconfiguration and emit +# user-friendly hints instead of false-positive error messages. +suggestion-mode=yes + +# Allow loading of arbitrary C extensions. Extensions are imported into the +# active Python interpreter and may run arbitrary code. +unsafe-load-any-extension=no + + +[MESSAGES CONTROL] + +# Only show warnings with the listed confidence levels. Leave empty to show +# all. Valid levels: HIGH, INFERENCE, INFERENCE_FAILURE, UNDEFINED. +confidence= + +# Disable the message, report, category or checker with the given id(s). You +# can either give multiple identifiers separated by comma (,) or put this +# option multiple times (only on the command line, not in the configuration +# file where it should appear only once). You can also use "--disable=all" to +# disable everything first and then reenable specific checks. For example, if +# you want to run only the similarities checker, you can use "--disable=all +# --enable=similarities". If you want to run only the classes checker, but have +# no Warning level messages displayed, use "--disable=all --enable=classes +# --disable=W". +disable=print-statement, + parameter-unpacking, + unpacking-in-except, + old-raise-syntax, + backtick, + long-suffix, + old-ne-operator, + old-octal-literal, + import-star-module-level, + non-ascii-bytes-literal, + raw-checker-failed, + bad-inline-option, + locally-disabled, + file-ignored, + suppressed-message, + useless-suppression, + deprecated-pragma, + use-symbolic-message-instead, + apply-builtin, + basestring-builtin, + buffer-builtin, + cmp-builtin, + coerce-builtin, + execfile-builtin, + file-builtin, + long-builtin, + raw_input-builtin, + reduce-builtin, + standarderror-builtin, + unicode-builtin, + xrange-builtin, + coerce-method, + delslice-method, + getslice-method, + setslice-method, + no-absolute-import, + old-division, + dict-iter-method, + dict-view-method, + next-method-called, + metaclass-assignment, + indexing-exception, + raising-string, + reload-builtin, + oct-method, + hex-method, + nonzero-method, + cmp-method, + input-builtin, + round-builtin, + intern-builtin, + unichr-builtin, + map-builtin-not-iterating, + zip-builtin-not-iterating, + range-builtin-not-iterating, + filter-builtin-not-iterating, + using-cmp-argument, + eq-without-hash, + div-method, + idiv-method, + rdiv-method, + exception-message-attribute, + invalid-str-codec, + sys-max-int, + bad-python3-import, + deprecated-string-function, + deprecated-str-translate-call, + deprecated-itertools-function, + deprecated-types-field, + next-method-defined, + dict-items-not-iterating, + dict-keys-not-iterating, + dict-values-not-iterating, + deprecated-operator-function, + deprecated-urllib-function, + xreadlines-attribute, + deprecated-sys-function, + exception-escape, + comprehension-escape, + duplicate-code + +# Enable the message, report, category or checker with the given id(s). You can +# either give multiple identifier separated by comma (,) or put this option +# multiple time (only on the command line, not in the configuration file where +# it should appear only once). See also the "--disable" option for examples. +enable=c-extension-no-member + + +[REPORTS] + +# Python expression which should return a score less than or equal to 10. You +# have access to the variables 'error', 'warning', 'refactor', and 'convention' +# which contain the number of messages in each category, as well as 'statement' +# which is the total number of statements analyzed. This score is used by the +# global evaluation report (RP0004). +evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / statement) * 10) + +# Template used to display messages. This is a python new-style format string +# used to format the message information. See doc for all details. +#msg-template= + +# Set the output format. Available formats are text, parseable, colorized, json +# and msvs (visual studio). You can also give a reporter class, e.g. +# mypackage.mymodule.MyReporterClass. +output-format=text + +# Tells whether to display a full report or only the messages. +reports=no + +# Activate the evaluation score. +score=yes + + +[REFACTORING] + +# Maximum number of nested blocks for function / method body +max-nested-blocks=5 + +# Complete name of functions that never returns. When checking for +# inconsistent-return-statements if a never returning function is called then +# it will be considered as an explicit return statement and no message will be +# printed. +never-returning-functions=sys.exit + + +[LOGGING] + +# Format style used to check logging format string. `old` means using % +# formatting, `new` is for `{}` formatting,and `fstr` is for f-strings. +logging-format-style=old + +# Logging modules to check that the string format arguments are in logging +# function parameter format. +logging-modules=logging + + +[SPELLING] + +# Limits count of emitted suggestions for spelling mistakes. +max-spelling-suggestions=4 + +# Spelling dictionary name. Available dictionaries: none. To make it work, +# install the python-enchant package. +spelling-dict= + +# List of comma separated words that should not be checked. +spelling-ignore-words= + +# A path to a file that contains the private dictionary; one word per line. +spelling-private-dict-file= + +# Tells whether to store unknown words to the private dictionary (see the +# --spelling-private-dict-file option) instead of raising a message. +spelling-store-unknown-words=no + + +[MISCELLANEOUS] + +# List of note tags to take in consideration, separated by a comma. +notes=FIXME, + XXX, + TODO + + +[TYPECHECK] + +# List of decorators that produce context managers, such as +# contextlib.contextmanager. Add to this list to register other decorators that +# produce valid context managers. +contextmanager-decorators=contextlib.contextmanager + +# List of members which are set dynamically and missed by pylint inference +# system, and so shouldn't trigger E1101 when accessed. Python regular +# expressions are accepted. +generated-members= + +# Tells whether missing members accessed in mixin class should be ignored. A +# mixin class is detected if its name ends with "mixin" (case insensitive). +ignore-mixin-members=yes + +# Tells whether to warn about missing members when the owner of the attribute +# is inferred to be None. +ignore-none=yes + +# This flag controls whether pylint should warn about no-member and similar +# checks whenever an opaque object is returned when inferring. The inference +# can return multiple potential results while evaluating a Python object, but +# some branches might not be evaluated, which results in partial inference. In +# that case, it might be useful to still emit no-member and other checks for +# the rest of the inferred objects. +ignore-on-opaque-inference=yes + +# List of class names for which member attributes should not be checked (useful +# for classes with dynamically set attributes). This supports the use of +# qualified names. +ignored-classes=optparse.Values,thread._local,_thread._local + +# List of module names for which member attributes should not be checked +# (useful for modules/projects where namespaces are manipulated during runtime +# and thus existing member attributes cannot be deduced by static analysis). It +# supports qualified module names, as well as Unix pattern matching. +ignored-modules= + +# Show a hint with possible names when a member name was not found. The aspect +# of finding the hint is based on edit distance. +missing-member-hint=yes + +# The minimum edit distance a name should have in order to be considered a +# similar match for a missing member name. +missing-member-hint-distance=1 + +# The total number of similar names that should be taken in consideration when +# showing a hint for a missing member. +missing-member-max-choices=1 + +# List of decorators that change the signature of a decorated function. +signature-mutators= + + +[VARIABLES] + +# List of additional names supposed to be defined in builtins. Remember that +# you should avoid defining new builtins when possible. +additional-builtins= + +# Tells whether unused global variables should be treated as a violation. +allow-global-unused-variables=yes + +# List of strings which can identify a callback function by name. A callback +# name must start or end with one of those strings. +callbacks=cb_, + _cb + +# A regular expression matching the name of dummy variables (i.e. expected to +# not be used). +dummy-variables-rgx=_+$|(_[a-zA-Z0-9_]*[a-zA-Z0-9]+?$)|dummy|^ignored_|^unused_ + +# Argument names that match this expression will be ignored. Default to name +# with leading underscore. +ignored-argument-names=_.*|^ignored_|^unused_ + +# Tells whether we should check for unused import in __init__ files. +init-import=no + +# List of qualified module names which can have objects that can redefine +# builtins. +redefining-builtins-modules=six.moves,past.builtins,future.builtins,builtins,io + + +[FORMAT] + +# Expected format of line ending, e.g. empty (any line ending), LF or CRLF. +expected-line-ending-format= + +# Regexp for a line that is allowed to be longer than the limit. +ignore-long-lines=^\s*(# )??$ + +# Number of spaces of indent required inside a hanging or continued line. +indent-after-paren=4 + +# String used as indentation unit. This is usually " " (4 spaces) or "\t" (1 +# tab). +indent-string=' ' + +# Maximum number of characters on a single line. +max-line-length=100 + +# Maximum number of lines in a module. +max-module-lines=1000 + +# List of optional constructs for which whitespace checking is disabled. `dict- +# separator` is used to allow tabulation in dicts, etc.: {1 : 1,\n222: 2}. +# `trailing-comma` allows a space between comma and closing bracket: (a, ). +# `empty-line` allows space-only lines. +no-space-check=trailing-comma, + dict-separator + +# Allow the body of a class to be on the same line as the declaration if body +# contains single statement. +single-line-class-stmt=no + +# Allow the body of an if to be on the same line as the test if there is no +# else. +single-line-if-stmt=no + + +[SIMILARITIES] + +# Ignore comments when computing similarities. +ignore-comments=yes + +# Ignore docstrings when computing similarities. +ignore-docstrings=yes + +# Ignore imports when computing similarities. +ignore-imports=no + +# Minimum lines number of a similarity. +min-similarity-lines=4 + + +[BASIC] + +# Naming style matching correct argument names. +argument-naming-style=snake_case + +# Regular expression matching correct argument names. Overrides argument- +# naming-style. +#argument-rgx= + +# Naming style matching correct attribute names. +attr-naming-style=snake_case + +# Regular expression matching correct attribute names. Overrides attr-naming- +# style. +#attr-rgx= + +# Bad variable names which should always be refused, separated by a comma. +bad-names=foo, + bar, + baz, + toto, + tutu, + tata + +# Naming style matching correct class attribute names. +class-attribute-naming-style=any + +# Regular expression matching correct class attribute names. Overrides class- +# attribute-naming-style. +#class-attribute-rgx= + +# Naming style matching correct class names. +class-naming-style=PascalCase + +# Regular expression matching correct class names. Overrides class-naming- +# style. +#class-rgx= + +# Naming style matching correct constant names. +const-naming-style=UPPER_CASE + +# Regular expression matching correct constant names. Overrides const-naming- +# style. +#const-rgx= + +# Minimum line length for functions/classes that require docstrings, shorter +# ones are exempt. +docstring-min-length=-1 + +# Naming style matching correct function names. +function-naming-style=snake_case + +# Regular expression matching correct function names. Overrides function- +# naming-style. +#function-rgx= + +# Good variable names which should always be accepted, separated by a comma. +good-names=i, + j, + k, + ex, + Run, + _ + +# Include a hint for the correct naming format with invalid-name. +include-naming-hint=no + +# Naming style matching correct inline iteration names. +inlinevar-naming-style=any + +# Regular expression matching correct inline iteration names. Overrides +# inlinevar-naming-style. +#inlinevar-rgx= + +# Naming style matching correct method names. +method-naming-style=snake_case + +# Regular expression matching correct method names. Overrides method-naming- +# style. +#method-rgx= + +# Naming style matching correct module names. +module-naming-style=snake_case + +# Regular expression matching correct module names. Overrides module-naming- +# style. +#module-rgx= + +# Colon-delimited sets of names that determine each other's naming style when +# the name regexes allow several styles. +name-group= + +# Regular expression which should only match function or class names that do +# not require a docstring. +no-docstring-rgx=^_ + +# List of decorators that produce properties, such as abc.abstractproperty. Add +# to this list to register other decorators that produce valid properties. +# These decorators are taken in consideration only for invalid-name. +property-classes=abc.abstractproperty + +# Naming style matching correct variable names. +variable-naming-style=snake_case + +# Regular expression matching correct variable names. Overrides variable- +# naming-style. +#variable-rgx= + + +[STRING] + +# This flag controls whether the implicit-str-concat-in-sequence should +# generate a warning on implicit string concatenation in sequences defined over +# several lines. +check-str-concat-over-line-jumps=no + + +[IMPORTS] + +# List of modules that can be imported at any level, not just the top level +# one. +allow-any-import-level= + +# Allow wildcard imports from modules that define __all__. +allow-wildcard-with-all=no + +# Analyse import fallback blocks. This can be used to support both Python 2 and +# 3 compatible code, which means that the block might have code that exists +# only in one or another interpreter, leading to false positives when analysed. +analyse-fallback-blocks=no + +# Deprecated modules which should not be used, separated by a comma. +deprecated-modules=optparse,tkinter.tix + +# Create a graph of external dependencies in the given file (report RP0402 must +# not be disabled). +ext-import-graph= + +# Create a graph of every (i.e. internal and external) dependencies in the +# given file (report RP0402 must not be disabled). +import-graph= + +# Create a graph of internal dependencies in the given file (report RP0402 must +# not be disabled). +int-import-graph= + +# Force import order to recognize a module as part of the standard +# compatibility libraries. +known-standard-library= + +# Force import order to recognize a module as part of a third party library. +known-third-party=enchant + +# Couples of modules and preferred modules, separated by a comma. +preferred-modules= + + +[CLASSES] + +# List of method names used to declare (i.e. assign) instance attributes. +defining-attr-methods=__init__, + __new__, + setUp, + __post_init__ + +# List of member names, which should be excluded from the protected access +# warning. +exclude-protected=_asdict, + _fields, + _replace, + _source, + _make + +# List of valid names for the first argument in a class method. +valid-classmethod-first-arg=cls + +# List of valid names for the first argument in a metaclass class method. +valid-metaclass-classmethod-first-arg=cls + + +[DESIGN] + +# Maximum number of arguments for function / method. +max-args=5 + +# Maximum number of attributes for a class (see R0902). +max-attributes=7 + +# Maximum number of boolean expressions in an if statement (see R0916). +max-bool-expr=5 + +# Maximum number of branch for function / method body. +max-branches=12 + +# Maximum number of locals for function / method body. +max-locals=15 + +# Maximum number of parents for a class (see R0901). +max-parents=7 + +# Maximum number of public methods for a class (see R0904). +max-public-methods=20 + +# Maximum number of return / yield for function / method body. +max-returns=6 + +# Maximum number of statements in function / method body. +max-statements=50 + +# Minimum number of public methods for a class (see R0903). +min-public-methods=2 + + +[EXCEPTIONS] + +# Exceptions that will emit a warning when being caught. Defaults to +# "BaseException, Exception". +overgeneral-exceptions=BaseException, + Exception diff --git a/.travis.yml b/.travis.yml index c1872c22e..336526dda 100644 --- a/.travis.yml +++ b/.travis.yml @@ -106,3 +106,19 @@ jobs: env: - DOCKER_IMAGE=continuumio/anaconda3:2020.02 - NOTEBOOK_PATH=recipes/getting-started/getting_started-image_classification.ipynb + - &test-pylint + stage: Test *.py with pylint + script: + - echo "$DOCKER_PASSWORD" | docker login -u "$DOCKER_USERNAME" --password-stdin + - docker pull ${DOCKER_IMAGE} + - | + docker run \ + ${DOCKER_IMAGE} /bin/sh -c "cd /root && \ + apt-get update && apt-get install -y gcc && \ + git clone --branch ${TRAVIS_BRANCH} https://github.com/kili-technology/kili-playground.git && \ + pip install pylint && \ + cd kili-playground && \ + pip install -r requirements.txt && \ + pylint kili" + env: + - DOCKER_IMAGE=continuumio/anaconda3:2020.02 diff --git a/kili/graphql_client.py b/kili/graphql_client.py index 63d62d1e4..0e501a39b 100644 --- a/kili/graphql_client.py +++ b/kili/graphql_client.py @@ -80,15 +80,15 @@ def _send(self, query, variables): return req.json() except Exception as exception: if req is not None: - raise Exception(req.content) + raise Exception(req.content) from exception raise exception req = urllib.request.Request( self.endpoint, json.dumps(data).encode('utf-8'), headers) try: - response = urllib.request.urlopen(req) - str_json = response.read().decode('utf-8') - return json.loads(str_json) + with urllib.request.urlopen(req) as response: + str_json = response.read().decode('utf-8') + return json.loads(str_json) except urllib.error.HTTPError as error: print((error.read())) print('') diff --git a/kili/helpers.py b/kili/helpers.py index 3c38545b7..183bb4e87 100644 --- a/kili/helpers.py +++ b/kili/helpers.py @@ -44,10 +44,10 @@ def __call__(self, resolver, *args, **kwargs): def checked_resolver(*args, **kwargs): try: client_endpoint = args[0].auth.client.endpoint - except: + except Exception as exception: raise ValueError( 'Cannot find client endpoint from resolver' \ - f' {resolver.__name__} with arguments {args}') + f' {resolver.__name__} with arguments {args}') from exception if self.client_is_compatible(client_endpoint): return resolver(*args, **kwargs) raise EndpointCompatibilityError( @@ -154,17 +154,17 @@ def format_json_dict(result): if key in ['jsonInterface', 'jsonMetadata', 'jsonResponse', 'rules']: if (value == '' or value is None) \ and not (is_url(value) and key == 'jsonInterface'): - result[key] = dict() + result[key] = {} elif isinstance(value, str): try: if is_url(value): result[key] = requests.get(value).json() else: result[key] = loads(value) - except: + except Exception as exception: raise ValueError( 'Json Metadata / json response /' \ - ' json interface / rules should be valid jsons') + ' json interface / rules should be valid jsons') from exception else: result[key] = format_json(value) return result diff --git a/kili/mutations/asset/__init__.py b/kili/mutations/asset/__init__.py index b19ab0786..e42245c43 100644 --- a/kili/mutations/asset/__init__.py +++ b/kili/mutations/asset/__init__.py @@ -112,7 +112,7 @@ def append_many_to_dataset( if content_array is None and json_content_array is None: raise ValueError( - f"Variables content_array and json_content_array cannot be both None.") + "Variables content_array and json_content_array cannot be both None.") if content_array is None: content_array = [''] * len(json_content_array) if external_id_array is None: diff --git a/kili/mutations/project/queries.py b/kili/mutations/project/queries.py index a6bf4e060..a44529e8d 100644 --- a/kili/mutations/project/queries.py +++ b/kili/mutations/project/queries.py @@ -78,7 +78,7 @@ }} ''' -GQL_MAKE_PROJECT_PUBLIC = f''' +GQL_MAKE_PROJECT_PUBLIC = ''' mutation( $projectID: ID! ) {{ @@ -153,7 +153,7 @@ }} ''' -GQL_PROJECT_DELETE_ASYNCHRONOUSLY = f''' +GQL_PROJECT_DELETE_ASYNCHRONOUSLY = ''' mutation($projectID: ID!) {{ data: deleteProjectAsynchronously(where: {{ id: $projectID diff --git a/kili/orm.py b/kili/orm.py index aba469843..ce423fa5b 100644 --- a/kili/orm.py +++ b/kili/orm.py @@ -10,7 +10,7 @@ class DictClass(dict): """ def __init__(self, *args, **kwargs): - super(DictClass, self).__init__(*args, **kwargs) + super().__init__(*args, **kwargs) self.__dict__ = self @dataclass @@ -142,7 +142,7 @@ class Asset(DictClass): """ def __init__(self, *args, **kwargs): - super(Asset, self).__init__(*args, **kwargs) + super().__init__(*args, **kwargs) if 'labels' in self: labels = [] for label in self['labels']: diff --git a/kili/queries/asset/queries.py b/kili/queries/asset/queries.py index 9246353c9..2c752a5da 100644 --- a/kili/queries/asset/queries.py +++ b/kili/queries/asset/queries.py @@ -14,7 +14,7 @@ def gql_assets(fragment): }} ''' -GQL_ASSETS_COUNT = f''' +GQL_ASSETS_COUNT = ''' query($where: AssetWhere!) {{ data: countAssets(where: $where) }} diff --git a/kili/queries/dataset_asset/queries.py b/kili/queries/dataset_asset/queries.py index 84130ae2f..d050ad3a6 100644 --- a/kili/queries/dataset_asset/queries.py +++ b/kili/queries/dataset_asset/queries.py @@ -15,7 +15,7 @@ def gql_assets(fragment): ''' -GQL_DATASET_ASSETS_COUNT = f''' +GQL_DATASET_ASSETS_COUNT = ''' query($where: DatasetAssetWhere!) {{ data: countDatasetAssets(where: $where) }} diff --git a/kili/queries/issue/queries.py b/kili/queries/issue/queries.py index cde5ac6ce..af1a69e7c 100644 --- a/kili/queries/issue/queries.py +++ b/kili/queries/issue/queries.py @@ -15,7 +15,7 @@ def gql_issues(fragment): ''' -GQL_LABELS_COUNT = f''' +GQL_LABELS_COUNT = ''' query($where: IssueWhere!) {{ data: countIssues(where: $where) }} diff --git a/kili/queries/label/queries.py b/kili/queries/label/queries.py index a97593252..4cc6b30db 100644 --- a/kili/queries/label/queries.py +++ b/kili/queries/label/queries.py @@ -15,7 +15,7 @@ def gql_labels(fragment): ''' -GQL_LABELS_COUNT = f''' +GQL_LABELS_COUNT = ''' query($where: LabelWhere!) {{ data: countLabels(where: $where) }} diff --git a/kili/queries/lock/queries.py b/kili/queries/lock/queries.py index 52be9bf35..c257ba96f 100644 --- a/kili/queries/lock/queries.py +++ b/kili/queries/lock/queries.py @@ -14,7 +14,7 @@ def gql_locks(fragment): }} ''' -GQL_LOCKS_COUNT = f''' +GQL_LOCKS_COUNT = ''' query($where: LockWhere!) {{ data: countLocks(where: $where) }} diff --git a/kili/queries/notification/queries.py b/kili/queries/notification/queries.py index 7c6326f94..e7132812a 100644 --- a/kili/queries/notification/queries.py +++ b/kili/queries/notification/queries.py @@ -15,7 +15,7 @@ def gql_notifications(fragment): ''' -GQL_NOTIFICATIONS_COUNT = f''' +GQL_NOTIFICATIONS_COUNT = ''' query($where: NotificationWhere!) {{ data: countNotifications(where: $where) }} diff --git a/kili/queries/organization/queries.py b/kili/queries/organization/queries.py index 2b5f65464..b4fe38446 100644 --- a/kili/queries/organization/queries.py +++ b/kili/queries/organization/queries.py @@ -14,7 +14,7 @@ def gql_organizations(fragment): }} ''' -GQL_ORGANIZATIONS_COUNT = f''' +GQL_ORGANIZATIONS_COUNT = ''' query($where: OrganizationWhere!) {{ data: countOrganizations(where: $where) }} diff --git a/kili/queries/project/queries.py b/kili/queries/project/queries.py index df06e6215..d674eec3f 100644 --- a/kili/queries/project/queries.py +++ b/kili/queries/project/queries.py @@ -14,7 +14,7 @@ def gql_projects(fragment: str): }} ''' -GQL_PROJECTS_COUNT = f''' +GQL_PROJECTS_COUNT = ''' query($where: ProjectWhere!) {{ data: countProjects(where: $where) }} diff --git a/kili/queries/project_user/queries.py b/kili/queries/project_user/queries.py index 0f51c6208..5564780f5 100644 --- a/kili/queries/project_user/queries.py +++ b/kili/queries/project_user/queries.py @@ -15,7 +15,7 @@ def gql_project_users(fragment): ''' -GQL_PROJECT_USERS_COUNT = f''' +GQL_PROJECT_USERS_COUNT = ''' query($where: ProjectUserWhere!) {{ data: countProjectUsers(where: $where) }} diff --git a/kili/queries/project_version/queries.py b/kili/queries/project_version/queries.py index 8dea5d98c..b9f5da87b 100644 --- a/kili/queries/project_version/queries.py +++ b/kili/queries/project_version/queries.py @@ -15,7 +15,7 @@ def gql_project_version(fragment): ''' -GQL_PROJECT_VERSION_COUNT = f''' +GQL_PROJECT_VERSION_COUNT = ''' query($where: ProjectVersionWhere!) {{ data: countProjectVersions(where: $where) }} diff --git a/kili/queries/user/queries.py b/kili/queries/user/queries.py index 4d3de4988..6c40fa9b6 100644 --- a/kili/queries/user/queries.py +++ b/kili/queries/user/queries.py @@ -15,7 +15,7 @@ def gql_users(fragment): ''' -GQL_USERS_COUNT = f''' +GQL_USERS_COUNT = ''' query($where: UserWhere!) {{ data: countUsers(where: $where) }} diff --git a/kili/transfer_learning.py b/kili/transfer_learning.py index 9c947091c..6b1c84d87 100644 --- a/kili/transfer_learning.py +++ b/kili/transfer_learning.py @@ -88,9 +88,10 @@ def launch_train(self): if len(self.assets_seen_in_training) == 0: filtered_assets_to_train = assets_to_train else: - filtered_assets_to_train = [asset for asset in assets_to_train - if all([asset['id'] not in training - for training in self.assets_seen_in_training])] + filtered_assets_to_train = [ + asset for asset in assets_to_train + if all([asset['id'] not in training # pylint: disable=use-a-generator + for training in self.assets_seen_in_training])] if len(filtered_assets_to_train) >= self.minimum_number_of_assets_to_launch_training: TransferLearning.train(filtered_assets_to_train) self.current_training_number += 1 @@ -139,8 +140,8 @@ def launch_tensorboard(): Launches the tensorboard """ print('Starting Tensorboard...') - subprocess.Popen(['tensorboard', '--logdir=runs']) - print('You can access Tensorboard at http://localhost:6006\n') + with subprocess.Popen(['tensorboard', '--logdir=runs']): + print('You can access Tensorboard at http://localhost:6006\n') def launch(self): """ diff --git a/requirements.txt b/requirements.txt new file mode 100644 index 000000000..d8dc11bd3 --- /dev/null +++ b/requirements.txt @@ -0,0 +1,6 @@ +pandas==1.2.5 +requests +six +tqdm +typeguard +websocket-client \ No newline at end of file