Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catalog get command, fix dev clock command #13

Merged
merged 3 commits into from Sep 4, 2019

Conversation

@fieryorc
Copy link

commented Aug 29, 2019

Fix clock command as it requires api key and secret now.
Add catalog get command that returns catalog xml.

Prem Ramanathan added 2 commits Aug 29, 2019
Prem Ramanathan
Add catalog get command
Change-Id: Ibe6a4ba1b9d03942f2eec0930392341591a86cb9
Prem Ramanathan
Fix clock command
 - It now requires API key/secret

Change-Id: I14fdcc9c14efff38d6bfa76aa543a221edc8d5f0
@pierre
Copy link
Member

left a comment

Looking good, just one typo in the docs to fix.

FYI I verified that the patch applies cleanly and works as expected in the work-for-release-0.21.x branch.

kbcmd/commands/catalog.go Outdated Show resolved Hide resolved
Prem Ramanathan
fix code review comments
Change-Id: I353191a75716b5caf37d3bc68afdc12bd10cd1b8
@pierre
pierre approved these changes Sep 4, 2019

@pierre pierre merged commit 46add25 into killbill:master Sep 4, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.