Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify credit screen to be compatible with api change #252

Open
wants to merge 3 commits into
base: work-for-release-0.21.x
from

Conversation

Projects
None yet
2 participants
@sbrossie
Copy link
Member

commented Jun 5, 2019

No description provided.

@pierre

pierre approved these changes Jun 8, 2019

else
redirect_to kaui_engine.account_path(credit.account_id)
redirect_to kaui_engine.account_path(credits[0].account_id)

This comment has been minimized.

Copy link
@pierre

pierre Jun 8, 2019

Member

FYI (but I don't think it's worth fixing right now) we're not quite consistent in the Ruby client. The tax API will return the refreshed credit instead: https://github.com/killbill/killbill-client-ruby/blob/8c59e5f3349f9caafccf03257125c5ca8a0e3b63/lib/killbill_client/models/invoice_item.rb#L98.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.