Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds applepay and googlepay support #102

Merged
merged 2 commits into from Apr 12, 2019

Conversation

Projects
None yet
3 participants
@alenad
Copy link
Contributor

alenad commented Mar 21, 2019

No description provided.

@alenad

This comment has been minimized.

Copy link
Contributor Author

alenad commented Mar 21, 2019

@pierre

This comment has been minimized.

Copy link
Member

pierre commented Mar 21, 2019

@alenad Could you add some tests?

@alenad

This comment has been minimized.

Copy link
Contributor Author

alenad commented Apr 9, 2019

@alenad Could you add some tests?

@pierre @daliwei tests added

@pierre
Copy link
Member

pierre left a comment

@daliwei Could you take a look as well? Thanks!

paymentInfo.setMpiDataDirectoryResponse("Y");
paymentInfo.setMpiDataAuthenticationResponse("Y");
if (mpiDataEci == null || mpiDataEci.isEmpty()) {
paymentInfo.setMpiDataEci("7");

This comment has been minimized.

Copy link
@pierre

pierre Apr 11, 2019

Member

Is it expected the brand overrides this value?

This comment has been minimized.

Copy link
@alenad

alenad Apr 11, 2019

Author Contributor

Yes, Adyen asked to send these values.

.build());
private final Iterable<PluginProperty> propertiesWithApplePay = PluginProperties.buildPluginProperties(ImmutableMap.<String, String>builder()
.put(AdyenPaymentPluginApi.PROPERTY_CC_LAST_NAME, "Applepaytester")
.put(AdyenPaymentPluginApi.PROPERTY_SELECTED_BRAND, "applepay")

This comment has been minimized.

Copy link
@pierre

pierre Apr 11, 2019

Member

Could you add a test with brand and without eci to verify the logic?

.put(AdyenPaymentPluginApi.PROPERTY_SELECTED_BRAND, "applepay")
.put(AdyenPaymentPluginApi.PROPERTY_MPI_DATA_CAVV, "AAAAAAAAt5fMJPDr320qAAALwwA=hq0BA9EAAAGXIJcAGAAAABKU0+s=")
.put(AdyenPaymentPluginApi.PROPERTY_MPI_DATA_ECI, "7")
.put(AdyenPaymentPluginApi.PROPERTY_CC_NUMBER, CC_3DS_NUMBER)

This comment has been minimized.

Copy link
@pierre

pierre Apr 11, 2019

Member

Why are you also passing a full PAN? Are you sure Adyen treats the request as an ApplePay one?

This comment has been minimized.

Copy link
@alenad

alenad Apr 12, 2019

Author Contributor

Why are you also passing a full PAN? Are you sure Adyen treats the request as an ApplePay one?

Yes, treats as applepay.

.put(AdyenPaymentPluginApi.PROPERTY_CC_EXPIRATION_YEAR, String.valueOf(CC_EXPIRATION_YEAR))
.put(AdyenPaymentPluginApi.PROPERTY_USER_AGENT, "Java/1.8")
.put(AdyenPaymentPluginApi.PROPERTY_ACCEPT_HEADER, "application/json")
.put(AdyenPaymentPluginApi.PROPERTY_TERM_URL, "dummy://url")

This comment has been minimized.

Copy link
@pierre

pierre Apr 11, 2019

Member

Probably not needed.

@sbrossie sbrossie merged commit 6f9dc8d into killbill:backport-0.18.x Apr 12, 2019

4 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-h2 Your tests passed on CircleCI!
Details
ci/circleci: test-mysql Your tests passed on CircleCI!
Details
ci/circleci: test-postgresql Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.