New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servlets improvements #86

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@pierre
Member

pierre commented Nov 2, 2018

Upgrade to Jooby... 馃槄

pierre added some commits Nov 1, 2018

servlets: remove legacy static UI
One should be using Kanaui instead.

Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
http: switch to Jooby
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
dao: harden code against payment plugins failures
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>

@pierre pierre requested a review from sbrossie Nov 2, 2018

@@ -418,14 +418,23 @@ protected Long getInvoicePaymentRecordId(final UUID invoicePaymentId, final Tena
error = e1;
}
}
} catch (final RuntimeException e) {

This comment has been minimized.

@sbrossie

sbrossie Nov 2, 2018

Member

What do you have in mind with catching this RuntimeException - are we trying to handle bug related exception or if not what is the scenario?

This comment has been minimized.

@pierre

pierre Nov 3, 2018

Member

If the payment plugin isn't well behaved and throws a RuntimeException (bug, misconfiguration, etc.), I think we still want to go ahead and refresh the Analytics data (without the plugin details).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment