Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance: introduce INVOICES group #95

Open
wants to merge 1 commit into
base: work-for-release-0.21.x
from

Conversation

Projects
None yet
2 participants
@pierre
Copy link
Member

commented Jun 6, 2019

Only refresh invoice and associated invoice item rows for INVOICE_CREATION and INVOICE_ADJUSTMENT events. See #93.

Verified the behavior by manual testing (by creating, adjusting and paying individual invoices, and verifying the state is correctly updated).

This depends on killbill/killbill#1143 for accuracy with CBA items.

Things to think about, as a reviewer, since it's a lot of code:

  • Is the assumption correct that INVOICE_CREATION and INVOICE_ADJUSTMENT events just need to update the associated invoice and account rows? The subscription CTD is also impacted for instance, but it looks like we are already missing it today (known bug?).
  • BusinessContextFactory does a lot of caching, across various objects. Is the logic correct? Is the synchronization correct?
performance: introduce INVOICES group
Only refresh invoice and associated invoice item rows for
INVOICE_CREATION and INVOICE_ADJUSTMENT events.

This depends on killbill/killbill#1143 for
accuracy with CBA items.

See #93.

Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>

@pierre pierre requested a review from sbrossie Jun 6, 2019

@sbrossie
Copy link
Member

left a comment

If i understand correctly this optimizes the use cases around invoice bus events to only recompute invoice stuff without having to deal with payments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.