Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mistake in credit api #64

merged 1 commit into from Jun 7, 2019


None yet
2 participants
Copy link

commented Jun 7, 2019

No description provided.


This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2019

@pierre Merging, but considering it took me 3 shots, worth a quick review :-)

@sbrossie sbrossie merged commit 1812a62 into work-for-release-0.21.x Jun 7, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Copy link

left a comment


diff --git a/tax.api b/credit.api
index 6fcc7570f..f22bbdbf6 100644
--- a/tax.api
+++ b/credit.api
@@ -1,2 +1,2 @@
public List<InvoiceItem> [-insertTaxItems(UUID-]{+insertCredits(UUID+} accountId, LocalDate effectiveDate, Iterable<InvoiceItem> [-taxes,-]{+creditItems,+} boolean autoCommit, Iterable<PluginProperty> properties, CallContext context) throws InvoiceApiException;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.