New invoice api for ability to group items in multiple invoices. #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrossie
commented
Apr 28, 2022
src/main/java/org/killbill/billing/invoice/api/InvoiceUserApi.java
Outdated
Show resolved
Hide resolved
Second pass on api: * Introduce separate triggerXXInvoiceGeneration for ease of incremental implementation (to be revisisted) * Add accountId getInvoicesByGroup (also for ease of impl. as it requires it for context to avoid extra queries/indices)
pierre
reviewed
May 3, 2022
| @@ -180,6 +193,8 @@ public interface InvoiceUserApi extends KillbillApi { | |||
| @RequiresPermissions(INVOICE_CAN_DRY_RUN_INVOICE) | |||
| public Invoice triggerDryRunInvoiceGeneration(UUID accountId, LocalDate targetDate, DryRunArguments dryRunArguments, CallContext context) throws InvoiceApiException; | |||
|
|
|||
| public Iterable<Invoice> triggerDryRunInvoiceGroupGeneration(UUID accountId, LocalDate targetDate, DryRunArguments dryRunArguments, CallContext context) throws InvoiceApiException; | |||
sbrossie
changed the title
sbrossie
changed the title
pierre
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See killbill/killbill#1658