Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add equals and toString to RequestOptions. #82

Merged
merged 1 commit into from Oct 9, 2019

Conversation

@brunner
Copy link

commented Sep 30, 2019

Discussed in https://groups.google.com/forum/#!topic/killbilling-users/ggP5aD5gSpo.

Let me know if the formatting / style look ok, or if there are any other tweaks you prefer!

@brunner

This comment has been minimized.

Copy link
Author

commented Sep 30, 2019

I'm going to double-check with Square's open source team that it is ok for me to be making these contributions. Please hold off on merging until I confirm!

@pierre pierre changed the title Add equals and toString to RequestOptions. [DO NOT MERGE] Add equals and toString to RequestOptions. Sep 30, 2019
@brunner

This comment has been minimized.

Copy link
Author

commented Oct 2, 2019

We received confirmation that it is ok to contribute :-) Thanks for waiting.

@brunner brunner changed the title [DO NOT MERGE] Add equals and toString to RequestOptions. Add equals and toString to RequestOptions. Oct 2, 2019
@@ -25,6 +25,7 @@
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.ImmutableMultimap;
import com.google.common.collect.Multimap;
import java.util.Objects;

This comment has been minimized.

Copy link
@pierre

pierre Oct 4, 2019

Member

@sbrossie I guess it's time we finally start using modern Java APIs (we don't support Java 6 anymore anyways since 0.20.x)? 👵 😏

Somewhat related to killbill/killbill#1203.

@pierre pierre merged commit 42ebdf5 into killbill:master Oct 9, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-h2 Your tests passed on CircleCI!
Details
@pierre

This comment has been minimized.

Copy link
Member

commented Oct 9, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.