Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify credit screen to be compatible with api change #72

Merged
merged 3 commits into from Jun 7, 2019

Conversation

Projects
None yet
2 participants
@sbrossie
Copy link
Member

commented Jun 5, 2019

No description provided.

@pierre
Copy link
Member

left a comment

I see a few generated models being deleted, is that expected?

Note also that CircleCI tests are failing:

  1) KillBillClient::Model should manipulate accounts
     Failure/Error: new_credit.credit_amount = 10.1
     
     NoMethodError:
       undefined method `credit_amount=' for #<KillBillClient::Model::Credit:0x6ba30587 @uri=nil>
     # ./spec/killbill_client/remote/model_spec.rb:302:in `(root)'
@sbrossie

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2019

@pierre Fixed the spec test in f631752

@sbrossie

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2019

@pierre Looked again at the gen file deleted, i think this is correct:

 .../gen/block_price_override_attributes.rb (gone)  |  37 --------
 .../gen/phase_price_override_attributes.rb (gone)  |  39 --------
 .../gen/tier_price_override_attributes.rb (gone)   |  34 -------
 .../gen/usage_price_override_attributes.rb (gone)  |  38 --------

None of these exist under our json models

@sbrossie

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2019

@pierre I will go ahead with the merge -- because this is what makes our ci integration failing i believe

@sbrossie sbrossie merged commit 4a21706 into work-for-release-0.21.x Jun 7, 2019

8 checks passed

ci/circleci: build-jruby-1.7.26 Your tests passed on CircleCI!
Details
ci/circleci: build-jruby-9.1.14.0 Your tests passed on CircleCI!
Details
ci/circleci: build-ruby-2.2.2 Your tests passed on CircleCI!
Details
ci/circleci: build-ruby-2.4.2 Your tests passed on CircleCI!
Details
ci/circleci: test-mysql-jruby-1.7.26 Your tests passed on CircleCI!
Details
ci/circleci: test-mysql-jruby-9.1.14.0 Your tests passed on CircleCI!
Details
ci/circleci: test-mysql-ruby-2.2.2 Your tests passed on CircleCI!
Details
ci/circleci: test-mysql-ruby-2.4.2 Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.