Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate kpm diagnostic in Docker #146

Merged
merged 3 commits into from May 2, 2019

Conversation

Projects
None yet
2 participants
@pierre
Copy link
Member

commented May 1, 2019

#145 should be merged first.

pierre added some commits Apr 30, 2019

docker: install Flyway in killbill image
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
ansible: docker: various cleanups
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
docker: integrate kpm diagnostic
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>

@pierre pierre requested a review from sbrossie May 1, 2019

logger)

killbill_account = data['killbill_account'].empty? ? nil : data['killbill_account']
diagnostic_file = diagnostic.export_data(killbill_account, data['log_dir'])

This comment has been minimized.

Copy link
@sbrossie

sbrossie May 1, 2019

Member

What happens if killbill_account is null ? Do we export all the tenant info ?

This comment has been minimized.

Copy link
@pierre

pierre May 2, 2019

Author Member

We always export the tenant config (i.e. all the key/values). If killbill_account is also specified, we export the data associated with that account (otherwise, we just skip that step).

@pierre pierre merged commit 211b37b into master May 2, 2019

8 checks passed

ci/circleci: build-jruby-1.7.26 Your tests passed on CircleCI!
Details
ci/circleci: build-jruby-9.1.14.0 Your tests passed on CircleCI!
Details
ci/circleci: build-ruby-2.2.2 Your tests passed on CircleCI!
Details
ci/circleci: build-ruby-2.4.2 Your tests passed on CircleCI!
Details
ci/circleci: test-mysql-jruby-1.7.26 Your tests passed on CircleCI!
Details
ci/circleci: test-mysql-jruby-9.1.14.0 Your tests passed on CircleCI!
Details
ci/circleci: test-mysql-ruby-2.2.2 Your tests passed on CircleCI!
Details
ci/circleci: test-mysql-ruby-2.4.2 Your tests passed on CircleCI!
Details

@pierre pierre deleted the kpm-diagnostic-docker branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.