Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

RuboCop integration #153

Merged
merged 26 commits into from Sep 6, 2019

Conversation

@pierre
Copy link
Member

commented Sep 6, 2019

RuboCop is now integrated with kpm:

kpm > bundle exec rubocop -a
Inspecting 60 files
............................................................

60 files inspected, no offenses detected

@sbrossie Merging the PR as I don't think there is anything worth reviewing. But if you have comments, feel free to add them 馃樃

pierre added 26 commits Sep 4, 2019
kpm: setup RuboCop
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: fix Layout/AlignArguments
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: fix Layout/AlignHash
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: fix Layout/EmptyLines
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: fix Layout/EmptyLinesAroundBlockBody
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: fix Layout/AccessModifierIndentation
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: fix Layout/*
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: fix various Style cops
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: fix various auto-correct cops
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
circleci: RuboCop integration
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
circleci: fix config
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: RuboCop iteration
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: RuboCop iteration
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: RuboCop iteration
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
circleci: upgrade Kill Bill version
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
Merge remote-tracking branch 'origin/work-for-release-0.21.x' into kp鈥
鈥-fixes

Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
circleci: RuboCop integration
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: fix regression on recent rubies
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
circleci: fix typo
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
circleci: fix typo
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: fix issues reported by RucoCop
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: fix issues reported by RucoCop
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: fix issues reported by RucoCop
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: fix issues reported by RucoCop
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: fix issues reported by RuboCop
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: fix issues reported by RuboCop
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>

@pierre pierre merged commit 4ab9af9 into work-for-release-0.21.x Sep 6, 2019

9 checks passed

ci/circleci: build-jruby-1.7.26 Your tests passed on CircleCI!
Details
ci/circleci: build-jruby-9.1.14.0 Your tests passed on CircleCI!
Details
ci/circleci: build-ruby-2.2.2 Your tests passed on CircleCI!
Details
ci/circleci: build-ruby-2.4.2 Your tests passed on CircleCI!
Details
ci/circleci: test-mysql-jruby-1.7.26 Your tests passed on CircleCI!
Details
ci/circleci: test-mysql-jruby-9.1.14.0 Your tests passed on CircleCI!
Details
ci/circleci: test-mysql-ruby-2.2.2 Your tests passed on CircleCI!
Details
ci/circleci: test-mysql-ruby-2.4.2 Your tests passed on CircleCI!
Details
ci/circleci: test-rubocop Your tests passed on CircleCI!
Details

@pierre pierre deleted the kpm-fixes branch Sep 6, 2019

@sbrossie

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

馃帀 Browsed through it... pretty cool indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.