Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostic fixes #154

Merged
merged 7 commits into from Sep 10, 2019

Conversation

@pierre
Copy link
Member

commented Sep 6, 2019

  • Fix regressions recently added
  • Add tests for system helpers
pierre added 7 commits Sep 6, 2019
kpm: fix formatter regression
String#% and format have two different signatures.

Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: add tests for cpu_information
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: add tests for disk_space_information
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: add tests for memory_information
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: add tests for entropy_available
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: fix specs on older Rubies
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: add tests for os_information
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>

@pierre pierre requested a review from sbrossie Sep 6, 2019

@pierre pierre merged commit c5e7eee into work-for-release-0.21.x Sep 10, 2019

9 checks passed

ci/circleci: build-jruby-1.7.26 Your tests passed on CircleCI!
Details
ci/circleci: build-jruby-9.1.14.0 Your tests passed on CircleCI!
Details
ci/circleci: build-ruby-2.2.2 Your tests passed on CircleCI!
Details
ci/circleci: build-ruby-2.4.2 Your tests passed on CircleCI!
Details
ci/circleci: test-mysql-jruby-1.7.26 Your tests passed on CircleCI!
Details
ci/circleci: test-mysql-jruby-9.1.14.0 Your tests passed on CircleCI!
Details
ci/circleci: test-mysql-ruby-2.2.2 Your tests passed on CircleCI!
Details
ci/circleci: test-mysql-ruby-2.4.2 Your tests passed on CircleCI!
Details
ci/circleci: test-rubocop Your tests passed on CircleCI!
Details

@pierre pierre deleted the diagnostic-fixes branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.