Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cleanup command #155

Merged
merged 6 commits into from Sep 12, 2019

Conversation

@pierre
Copy link
Member

commented Sep 10, 2019

  • Fix issue where Tomcat PID wasn't properly detected
  • Enhance README with high level description of commands (doesn't replace our documentation though, it's more like a quick reference for us)
  • Add kpm cleanup
pierre added 6 commits Sep 9, 2019
kpm: update README with caching behavior
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: document diagnostic commands
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: fix Tomcat PID detection in system command
This also cleans up the code a little bit.

Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: add --as-json option to kpm inspect
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: refactor uninstaller in preparation for cleanup command
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
kpm: add cleanup command
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>

@pierre pierre requested a review from sbrossie Sep 10, 2019

@sbrossie
Copy link
Member

left a comment

fyi: Did not see where the tomcat PID detection fix was

@pierre

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2019

fyi: Did not see where the tomcat PID detection fix was

Take a look at 9a86605#diff-095b4ef074cf133a3d35c965d55d1e34R275.

Basically:

2.4.1 :001 > foo
NameError: undefined local variable or method `foo' for main:Object
	from (irb):1
	from bin/irb:11:in `<main>'
2.4.1 :002 > def foo; puts('foo!'); end
 => :foo
2.4.1 :003 > foo
foo!
 => nil
2.4.1 :004 > foo = foo
 => nil
2.4.1 :005 > foo
 => nil
2.4.1 :006 > foo()
foo!
 => nil

Subtle...

@sbrossie

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

@pierre

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2019

But all i am seeing is that you renamed apache_tomcat_pid -> find_apache_tomcat_pid

Exactly, the issue was:

apache_tomcat_pid = apache_tomcat_pid

Left is local variable assignment, right was supposed to be the method call.

@sbrossie

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

Exactly, the issue was:

apache_tomcat_pid = apache_tomcat_pid
Left is local variable assignment, right was supposed to be the method call.

Ah, got it 💡

@pierre pierre merged commit 2d5eb7a into work-for-release-0.21.x Sep 12, 2019

9 checks passed

ci/circleci: build-jruby-1.7.26 Your tests passed on CircleCI!
Details
ci/circleci: build-jruby-9.1.14.0 Your tests passed on CircleCI!
Details
ci/circleci: build-ruby-2.2.2 Your tests passed on CircleCI!
Details
ci/circleci: build-ruby-2.4.2 Your tests passed on CircleCI!
Details
ci/circleci: test-mysql-jruby-1.7.26 Your tests passed on CircleCI!
Details
ci/circleci: test-mysql-jruby-9.1.14.0 Your tests passed on CircleCI!
Details
ci/circleci: test-mysql-ruby-2.2.2 Your tests passed on CircleCI!
Details
ci/circleci: test-mysql-ruby-2.4.2 Your tests passed on CircleCI!
Details
ci/circleci: test-rubocop Your tests passed on CircleCI!
Details

@pierre pierre deleted the add-cleanup-cmd branch Sep 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.