Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work for release 0.21.x tmp #30

Merged
merged 7 commits into from Jan 8, 2020

Conversation

@sbrossie
Copy link
Member

sbrossie commented Jan 8, 2020

Upgrade for 0.22.x releases

sbrossie added 4 commits Jan 7, 2020
@sbrossie sbrossie requested a review from pierre Jan 8, 2020
sbrossie added 2 commits Jan 8, 2020
…lbill-email-notifications-plugin into work-for-release-0.21.x-tmp
@pierre
pierre approved these changes Jan 8, 2020
Copy link
Member

pierre left a comment

Might be worth checking CircleCI too

README.md Outdated

The plugin comes with a set of [default templates](src/main/resources/org/killbill/billing/plugin/notification/templates) but one will typically want to upload his own templates. We are relying on the [mustache engine](https://mustache.github.io/) for the templating mechanism.

In addition to the templates, we all allow to upload some resources files to allow for string translations in different languages, e.g to have different trnslation for the catalog prodcut names, ...

This comment has been minimized.

Copy link
@pierre

pierre Jan 8, 2020

Member

Typos (trnslation, prodcut).

README.md Outdated

=> You should see an email sent for the invoice and succesuful payment

This comment has been minimized.

Copy link
@pierre

pierre Jan 8, 2020

Member

Typo: succesuful

@sbrossie sbrossie merged commit f9ffc12 into work-for-release-0.21.x Jan 8, 2020
1 check was pending
1 check was pending
ci/circleci: build CircleCI is running your tests
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.