Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various updates #32

Merged
merged 5 commits into from Feb 10, 2020
Merged

Various updates #32

merged 5 commits into from Feb 10, 2020

Conversation

@pierre
Copy link
Member

pierre commented Feb 6, 2020

See individual commits.

pierre added 4 commits Feb 6, 2020
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
@pierre pierre requested a review from sbrossie Feb 6, 2020

## SMTP & Email Type Configuration

### Tenant Configuration

Each tenant that requires the use of the plugin must be configured with the SMTP properties, and it can also specify the default set of emails that should be set. As indicated above, the plugin allows to be used to react to the following events:
`INVOICE_CREATION`, `UPCOMING_INVOICE`, `SUCCESSFUL_PAYMENT`, `FAILED_PAYMENT`, `PAYMENT_REFUND`, `SUBSCRIPTION_CANCELLATION_REQUESTED`, `SUBSCRIPTION_CANCELLATION_EFFECTIVE`:
`INVOICE_CREATION`, `INVOICE_NOTIFICATION`, `INVOICE_PAYMENT_SUCCESS`, `INVOICE_PAYMENT_FAILED`, and `SUBSCRIPTION_CANCEL`.

This comment has been minimized.

Copy link
@sbrossie

sbrossie Feb 6, 2020

Member

So fir the cancelation, we have no way to differentiate between requested and effective date ?

This comment has been minimized.

Copy link
@pierre

pierre Feb 6, 2020

Author Member

You must indeed subscribe to both events today:

case SUBSCRIPTION_CANCEL:
sendEmailForCancelledSubscription(account, killbillEvent, context);
break;

We allow for configuration of 2 different templates:

SUBSCRIPTION_CANCELLATION_REQUESTED("SubscriptionCancellationRequested.mustache", "subscriptionCancellationRequestedSubject"),
SUBSCRIPTION_CANCELLATION_EFFECTIVE("SubscriptionCancellationEffective.mustache", "subscriptionCancellationEffectiveSubject"),

but you cannot prevent requested cancellation emails to be sent out only for instance (if you don't configure a template, the default hardcoded one is used).

Something to review at some point...

@sbrossie

This comment has been minimized.

Copy link
Member

sbrossie commented Feb 6, 2020

@pierre pierre mentioned this pull request Feb 7, 2020
@pierre

This comment has been minimized.

Copy link
Member Author

pierre commented Feb 7, 2020

Tracked by #33

Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
@pierre pierre merged commit c1ef2e0 into master Feb 10, 2020
3 checks passed
3 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-h2 Your tests passed on CircleCI!
Details
ci/circleci: test-mysql Your tests passed on CircleCI!
Details
@pierre pierre deleted the docs-updates branch Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.