Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Various updates #32
Maybe file a GH so we don't forget?…
On Thu, Feb 6, 2020 at 11:59 AM Pierre-Alexandre Meyer < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In README.md <#32 (comment)> : > ## SMTP & Email Type Configuration ### Tenant Configuration Each tenant that requires the use of the plugin must be configured with the SMTP properties, and it can also specify the default set of emails that should be set. As indicated above, the plugin allows to be used to react to the following events: -`INVOICE_CREATION`, `UPCOMING_INVOICE`, `SUCCESSFUL_PAYMENT`, `FAILED_PAYMENT`, `PAYMENT_REFUND`, `SUBSCRIPTION_CANCELLATION_REQUESTED`, `SUBSCRIPTION_CANCELLATION_EFFECTIVE`: +`INVOICE_CREATION`, `INVOICE_NOTIFICATION`, `INVOICE_PAYMENT_SUCCESS`, `INVOICE_PAYMENT_FAILED`, and `SUBSCRIPTION_CANCEL`. You must indeed subscribe to both events today: https://github.com/killbill/killbill-email-notifications-plugin/blob/0e2eae4fa67513468870f28e7e80dd35844e7df6/src/main/java/org/killbill/billing/plugin/notification/setup/EmailNotificationListener.java#L147-L149 We allow for configuration of 2 different templates: https://github.com/killbill/killbill-email-notifications-plugin/blob/0e2eae4fa67513468870f28e7e80dd35844e7df6/src/main/java/org/killbill/billing/plugin/notification/templates/TemplateType.java#L29-L30 but you cannot prevent requested cancellation emails to be sent out only for instance (if you don't configure a template, the default hardcoded one is used). Something to review at some point... — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#32?email_source=notifications&email_token=AAB4I7TS32LT3SPHSTJ7C6DRBRTZ7A5CNFSM4KRCMCXKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUSMSBA#discussion_r376051281>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB4I7XNDXHJWGL3WRVE4BDRBRTZ7ANCNFSM4KRCMCXA> .
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.