New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby: handle timezone offsets #19

Merged
merged 1 commit into from Jan 21, 2019

Conversation

Projects
None yet
2 participants
@pierre
Copy link
Member

pierre commented Jan 2, 2019

Return the offset as a String, as we cannot directly map it to a timezone.

See killbill/killbill-plugin-framework-ruby#54.

ruby: handle timezone offsets
Return the offset as a String, as we cannot directly map it to
a timezone.

See killbill/killbill-plugin-framework-ruby#54.

Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>

@pierre pierre requested a review from sbrossie Jan 2, 2019

@sbrossie

This comment has been minimized.

Copy link
Member

sbrossie commented Jan 20, 2019

👍 I suppose in theory we should then regenerate all our ruby plugins?

@pierre

This comment has been minimized.

Copy link
Member

pierre commented Jan 21, 2019

👍 I suppose in theory we should then regenerate all our ruby plugins?

Yes, although in practice, the issue has only affected the Stripe plugin.

@pierre pierre merged commit 82fe20a into master Jan 21, 2019

@pierre pierre deleted the fix-for-killbill-plugin-framework-ruby-54 branch Jan 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment