Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass in properties of billing_agreement_type and billing_agreement_de… #37

Open
wants to merge 2 commits into
base: backport-0.18.x
from

Conversation

Projects
None yet
2 participants
@daliwei
Copy link
Contributor

daliwei commented Mar 8, 2019

…scription

cc @pierre

@pierre
Copy link
Member

pierre left a comment

Can you take a look at the CircleCI failures?

@@ -25,8 +25,8 @@ def initiate_express_checkout(kb_account_id, kb_tenant_id, amount_in_cents=0, cu

if with_baid
options[:billing_agreement] ||= {}
options[:billing_agreement][:type] ||= 'MerchantInitiatedBilling'
options[:billing_agreement][:description] ||= 'Kill Bill billing agreement'
options[:billing_agreement][:type] = options[:billing_agreement_type] || 'MerchantInitiatedBilling'

This comment has been minimized.

@pierre

pierre Mar 11, 2019

Member

Why not ||= anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.