Skip to content
This repository has been archived by the owner on May 19, 2022. It is now read-only.

Pass in properties of billing_agreement_type and billing_agreement_de… #37

Merged
merged 2 commits into from May 16, 2019
Merged

Pass in properties of billing_agreement_type and billing_agreement_de… #37

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d8e955
Pass in properties of billing_agreement_type and billing_agreement_de…
daliwei Mar 4, 2019
e71eee0
Use ||= for billing agreement parameters
daliwei Mar 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/paypal_express/private_api.rb
View file
Open in desktop
Expand Up @@ -25,8 +25,8 @@ def initiate_express_checkout(kb_account_id, kb_tenant_id, amount_in_cents=0, cu

if with_baid
options[:billing_agreement] ||= {}
options[:billing_agreement][:type] ||= 'MerchantInitiatedBilling'
options[:billing_agreement][:description] ||= 'Kill Bill billing agreement'
options[:billing_agreement][:type] = options[:billing_agreement_type] || 'MerchantInitiatedBilling'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not ||= anymore?

options[:billing_agreement][:description] = options[:billing_agreement_description] || 'Kill Bill billing agreement'
end

# Go to Paypal (SetExpressCheckout call)
Expand Down