Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1615 remove guava part 2 #112

Merged

Conversation

xsalefter
Copy link
Contributor

  • affecting modules: killbill-platform-server, killbill-platform-tests
  • remove temporary classes (AbstractInvocationHandler, Files) because these files already merged in killbill-commons.
  • I need to do bind(HealthCheckRegistry.class).toProvider(Providers.of(null)); in TestIntegrationModule. Pierre told me here. Also this SO post confirm that @Inject(optional=true) is not same as @Inject @Nullable.

@pierre pierre merged commit 62d3795 into killbill:work-for-release-0.23.x Aug 6, 2022
@xsalefter xsalefter deleted the 1615-remove_guava_part_2 branch August 9, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants