Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noisy PaymentRefresher logs for external payments #1111

Open
pierre opened this Issue Mar 1, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@pierre
Copy link
Member

pierre commented Mar 1, 2019

In PaymentRefresher, we log when we cannot find the PaymentTransactionInfoPlugin for a given PaymentTransactionModelDao. This is usually useful to detect misbehaving or mis-implemented plugins.

See

log.warn("Unable to find transaction={} from pluginTransactions={}", curPaymentTransactionModelDao, pluginTransactions);

Unfortunately, this is quite noisy for the (built-in) external payment plugin as it never has the information.

See

public List<PaymentTransactionInfoPlugin> getPaymentInfo(final UUID kbAccountId, final UUID kbPaymentId, final Iterable<PluginProperty> properties, final TenantContext context) throws PaymentPluginApiException {
return ImmutableList.of();
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.