Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment attempt amount isn't always populated #1281

Closed
pierre opened this issue Feb 13, 2020 · 0 comments
Closed

Payment attempt amount isn't always populated #1281

pierre opened this issue Feb 13, 2020 · 0 comments
Assignees
Labels
bug

Comments

@pierre
Copy link
Member

@pierre pierre commented Feb 13, 2020

When processing a JanitorNotificationKey for instance, and run the completion part of the state machine to call the plugins, we will update the state as needed:

retryablePaymentAutomatonRunner.getPaymentDao().updatePaymentAttemptWithProperties(attempt.getId(),

But not the amount (which is confusing if the state is SUCCESS). Note that the amount may not be initially inserted in the payment attempt, because it could be set by the prioriCall (e.g. invoice payment usecase).

This amount is only used to drive the retries, so it shouldn't be an issue if the state is SUCCESS, but we should address it.

@pierre pierre added the bug label Feb 13, 2020
@pierre pierre self-assigned this Feb 13, 2020
@sbrossie sbrossie closed this in 1247e39 Feb 14, 2020
@pierre pierre added this to the Release-0-20.16 milestone Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.