New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search invoices between start and end date. #651

Closed
webroboteu opened this Issue Nov 5, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@webroboteu

webroboteu commented Nov 5, 2016

I thinks that is only necessary to update the template of the jbdi framework:

searchQuery(prefix) ::= <<
<idField(prefix)> = :searchKey
or account_id = :searchKey
or currency = :searchKey

@pierre pierre added the enhancement label Nov 7, 2016

@pierre

This comment has been minimized.

Show comment
Hide comment
@pierre

pierre Feb 27, 2017

Member

Note that InvoiceUserApi already exposes:

List<Invoice> getInvoicesByAccount(UUID accountId, LocalDate fromDate, TenantContext context)

This is not exposed in JAX-RS today though.

Member

pierre commented Feb 27, 2017

Note that InvoiceUserApi already exposes:

List<Invoice> getInvoicesByAccount(UUID accountId, LocalDate fromDate, TenantContext context)

This is not exposed in JAX-RS today though.

@pierre pierre added this to the Release-0.20.0 milestone Apr 11, 2017

@sbrossie

This comment has been minimized.

Show comment
Hide comment
@sbrossie

sbrossie Oct 19, 2017

Member

/cc @pierre Is the proposal to just expose the endpoint, or also to add the toDate ?

Member

sbrossie commented Oct 19, 2017

/cc @pierre Is the proposal to just expose the endpoint, or also to add the toDate ?

@sbrossie sbrossie self-assigned this Oct 19, 2017

@pierre

This comment has been minimized.

Show comment
Hide comment
@pierre

pierre Oct 23, 2017

Member

I would just expose getInvoicesByAccount as-is in JAX-RS, not add anything new.

Member

pierre commented Oct 23, 2017

I would just expose getInvoicesByAccount as-is in JAX-RS, not add anything new.

@pierre

This comment has been minimized.

Show comment
Hide comment
@pierre

pierre Jun 16, 2018

Member

Work to be done is to expose a query parameter fromDate in JAX-RS (AccountResource#getInvoicesForAccount) and call the right getInvoicesByAccount API in the implementation.

  • Clients to regenerate and update
  • Slate to update
Member

pierre commented Jun 16, 2018

Work to be done is to expose a query parameter fromDate in JAX-RS (AccountResource#getInvoicesForAccount) and call the right getInvoicesByAccount API in the implementation.

  • Clients to regenerate and update
  • Slate to update
@sbrossie

This comment has been minimized.

Show comment
Hide comment
@sbrossie

sbrossie Jun 19, 2018

Member

/cc @pierre We do have the invoice api to use the startDate, but this api does not take into account the includesMigrated. This means we cannot both filter on startDate and return migrated invoices ? Would it be better to have one api with all 3 flags instead - or we don't care?

Member

sbrossie commented Jun 19, 2018

/cc @pierre We do have the invoice api to use the startDate, but this api does not take into account the includesMigrated. This means we cannot both filter on startDate and return migrated invoices ? Would it be better to have one api with all 3 flags instead - or we don't care?

@pierre

This comment has been minimized.

Show comment
Hide comment
@pierre

pierre Jun 20, 2018

Member

I would not change the API but always assume includesMigrated=true. Typically, these migrated invoices would be the first ones in the system, so to filter them out, one could simply pass a date post migration.

The main use-case for this API is for display purposes anyways (e.g. show invoices over the last 3 months), so we probably don't need too many bells and whistles 😼

Member

pierre commented Jun 20, 2018

I would not change the API but always assume includesMigrated=true. Typically, these migrated invoices would be the first ones in the system, so to filter them out, one could simply pass a date post migration.

The main use-case for this API is for display purposes anyways (e.g. show invoices over the last 3 months), so we probably don't need too many bells and whistles 😼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment