Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging a Account as AUTO_PAY_OFF/MANUAL_PAY should also apply #812

Closed
sbrossie opened this issue Oct 30, 2017 · 0 comments

Comments

@sbrossie
Copy link
Member

commented Oct 30, 2017

The discussion originated from the [Kill Bill user mailing] list(https://groups.google.com/forum/#!topic/killbilling-users/rhuEbQ3iEGk).

Currently the behavior is to first check if there is a missing payment method and then check for AUTO_PAY_OFF/MANUAL_PAY.

It would make more sense to reverse the check and abort the payment. This would avoid sending an INVOICE_PAYMENT_FAILURE event.

@sbrossie sbrossie added the PAYMENT label Oct 30, 2017
@sbrossie sbrossie self-assigned this Oct 30, 2017
@pierre pierre added this to the Release-0.21.5 milestone Sep 26, 2019
@pierre pierre assigned pierre and unassigned sbrossie Sep 30, 2019
pierre added a commit that referenced this issue Oct 1, 2019
This fixes #812.

Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
@sbrossie sbrossie closed this Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.