New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 282 #1072

Merged
merged 5 commits into from Dec 5, 2018

Conversation

Projects
None yet
1 participant
@pierre
Member

pierre commented Dec 5, 2018

See #282.

This also fixes the build after the recent merge (test issue) and integrates your comment w.r.t. dry-run and account BCD.

pierre added some commits Dec 4, 2018

invoice: make sure to take the lock before calling BillingInternalApi
Also process all account updates in transactions.

These fixes should patch the high concurrency bug described at #282.

Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
Merge branch 'master' into fix-for-282
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
beatrix: fix test failure
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
account: unify treatNullValueAsReset value in API
This one isn't used though.

Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
junction: run account BCD refresh even in dry-run mode
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>

@pierre pierre requested a review from sbrossie Dec 5, 2018

@pierre pierre merged commit 938aa3e into master Dec 5, 2018

5 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: integration-tests Your tests passed on CircleCI!
Details
ci/circleci: test-h2 Your tests passed on CircleCI!
Details
ci/circleci: test-mysql Your tests passed on CircleCI!
Details
ci/circleci: test-postgresql Your tests passed on CircleCI!
Details

@pierre pierre deleted the fix-for-282 branch Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment