Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work for payment control plugin fixes #1131

Merged

Conversation

Projects
None yet
2 participants
@sbrossie
Copy link
Member

sbrossie commented Apr 14, 2019

No description provided.

sbrossie added some commits Apr 14, 2019

Fix payment tests after adding the validation fix in 807e265. See #1097
This also removes overriding the paymentMethodId in the context from fetching it automatically
from the default Account#paymentMethod.
payment: Pass plugin name to control plugin during priorCall when pay…
…mentMethodId was specified or for subsequent transactions
@@ -48,6 +48,9 @@
private BigDecimal processedAmount;
private Currency processedCurrency;

private String originalPluginName;

This comment has been minimized.

Copy link
@pierre

pierre Apr 14, 2019

Member

Maybe rename it to originalPaymentPluginName?

@sbrossie sbrossie merged commit aaec51a into work-for-release-0.21.x Apr 16, 2019

5 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: integration-tests Your tests passed on CircleCI!
Details
ci/circleci: test-h2 Your tests passed on CircleCI!
Details
ci/circleci: test-mysql Your tests passed on CircleCI!
Details
ci/circleci: test-postgresql Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.