Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invoice: targetDate adjustment should be limited to invoices with REC… #1242

Merged
merged 1 commit into from Nov 5, 2019

Conversation

@sbrossie
Copy link
Member

sbrossie commented Nov 4, 2019

…URRING or USAGE items. See #1241

…URRING or USAGE items. See #1241
@sbrossie sbrossie requested a review from pierre Nov 4, 2019
@pierre
pierre approved these changes Nov 5, 2019

expectedInvoices.add(new ExpectedInvoiceItemCheck(new LocalDate(2019, 1, 1), new LocalDate(2019, 2, 1), InvoiceItemType.RECURRING, new BigDecimal("249.95")));

// Move through time and verify we get the same invoice

This comment has been minimized.

Copy link
@pierre

pierre Nov 5, 2019

Member

Confused by the comment, is there a checkInvoice missing?

This comment has been minimized.

Copy link
@sbrossie

sbrossie Nov 6, 2019

Author Member

Yep, fixed in 6415847

@sbrossie sbrossie merged commit 94852be into master Nov 5, 2019
5 checks passed
5 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: integration-tests Your tests passed on CircleCI!
Details
ci/circleci: test-h2 Your tests passed on CircleCI!
Details
ci/circleci: test-mysql Your tests passed on CircleCI!
Details
ci/circleci: test-postgresql Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.