Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 1276 #1280

Merged
merged 5 commits into from Feb 11, 2020
Merged

Fix for 1276 #1280

merged 5 commits into from Feb 11, 2020

Conversation

@sbrossie
Copy link
Member

sbrossie commented Feb 11, 2020

No description provided.

sbrossie added 4 commits Feb 7, 2020
… first __INVOICE_PAYMENT_CONTROL_PLUGIN__. See #1276
…ncorrect context

The context contained the wrong `pluginName` (te one from previous plugin invoked), and also
provides info about processed currency and amount which is inacurate.
@sbrossie sbrossie requested a review from pierre Feb 11, 2020
hppType,
inputAmount,
inputCurrency,
null,

This comment has been minimized.

Copy link
@pierre

pierre Feb 11, 2020

Member

Why this change?

FYI at least getProcessedCurrency is used in the invoice control plugin prior call (recordPaymentAttemptCompletion) -- are we sure null doesn't have any side effect?

This comment has been minimized.

Copy link
@sbrossie

sbrossie Feb 11, 2020

Author Member

I don't see where getProcessedCurrency is used in the invoice control plugin prior call -- i think the code you are pointing at is using the values from the successfulTransaction, not the context?

Stepping back: the processed currency/amount is the one that is used after the payment was made, so it makes little sense to pass it to the control plugin in the priorCall, hence the change.

That being said, i realize that this change is somewhat orthogonal to what i wanted to change (and therefore could be removed), i was taking the opportunity to clean up things. I can change it back.

Copy link
Member

pierre left a comment

See concern below.

@pierre
pierre approved these changes Feb 11, 2020
@sbrossie sbrossie merged commit 021130b into master Feb 11, 2020
5 checks passed
5 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: integration-tests Your tests passed on CircleCI!
Details
ci/circleci: test-h2 Your tests passed on CircleCI!
Details
ci/circleci: test-mysql Your tests passed on CircleCI!
Details
ci/circleci: test-postgresql Your tests passed on CircleCI!
Details
@pierre pierre deleted the fix-for-1276 branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.