Overly permissive docopt allows mutually exclusive package kinds

[bjgill]

Whilst debugging for #173, I discovered that it was possible to run cargo add failure --vers 0.4.3 --git git://git.git --path /path/here.

This exited successfully, having added failure = 0.0.1 to the manifest.

Printing out the docopt arguments yielded:

Args { arg_crate: "", arg_crates: ["failure"], flag_dev: false, flag_build: false, flag_vers: Some("0.4.3"), flag_git: Some("git://git.git"), flag_path: Some("/path/here"), flag_target: None, flag_optional: false, flag_manifest_path: None, flag_version: false, flag_upgrade: None, flag_allow_prerelease: false }

The browser-based version on http://docopt.org/ correctly rejects cargo add failure --vers 0.4.3 --git git://git.git --path /path/here. Thus, I suspect that this is likely to be a failure in the Rust implementation of docopt.

I'm planning to raise an issue with docopt-rs, linking back here.

I've got a test on a branch that should start succeeding when this issue is fixed: https://github.com/bjgill/cargo-edit/tree/docopt-failure.

[ordian]

We've switched to structopt, closing as stale.