New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-add accepts package names with mismatching hyphen/underscore without conversion #51

Closed
crumblingstatue opened this Issue Oct 23, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@crumblingstatue
Copy link

crumblingstatue commented Oct 23, 2015

Examples:

error_def

$ cargo add error-def
$ cargo build
    Updating registry `https://github.com/rust-lang/crates.io-index`
no matching package named `error-def` found (required by `undered`)

quick-error

$ cargo add quick_error
$ cargo build
    Updating registry `https://github.com/rust-lang/crates.io-index`
no matching package named `quick_error` found (required by `undered`)
@killercup

This comment has been minimized.

Copy link
Owner

killercup commented Oct 23, 2015

Yes. In some RFC, Cargo's name conversions are described pretty good. We should probably support those (maybe checking a few variations on error).

@killercup killercup added the easy label Feb 7, 2016

caulagi pushed a commit to caulagi/cargo-edit that referenced this issue Mar 4, 2016

@killercup

This comment has been minimized.

Copy link
Owner

killercup commented Jan 3, 2017

Fixed in #101

@killercup killercup closed this Jan 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment