New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional bits for giftwrap #8
Comments
I actually want How about making things conditional instead? I didn't really write about it, but here is what I imagine:
And, more controversially:
|
Those sound good to me. And I do use |
I personally hate visual indentation for most things
… Am 02.02.2017 um 15:00 schrieb Ben Boeckel ***@***.***>:
Those sound good to me.
And I do use rustfmt, but I do not apply all of its changes (they're usually issues with indentation mismatches, all of them bugs).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Yeah, but this is kind of stuff I'm talking about: Annoying, the arguments are related: let commit = ctx.git()
.arg("commit")
.arg("--allow-empty")
- .arg("-m").arg("root commit")
+ .arg("-m")
+ .arg("root commit")
.output()
.unwrap(); bugs: result.add_error(format!("commit {} is a known-bad commit that was removed from the \
server.",
- commit.sha1_short))
+ commit.sha1_short)) |
Yeah, I agree. The second one should be result.add_error(format!(
"commit {sha} is a known-bad commit that was removed from the server.",
sha = commit.sha1_short,
)) or I'm not gonna be happy… (Aside from that, you should probably use the |
|
Yeah, no |
(No activity for ≥30 days, closing) |
I like the idea, but it'd be nice if some things were optional, such as rustfmt (there are still bugs with it for some patterns; I need to collect them and file bugs), CI (not everyone uses CI that has artifacts in the repo, so some way to say "done externally" would be great), and potentially other things (not everyone uses git, so
.gitignore
).The text was updated successfully, but these errors were encountered: