New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

date format #1179

Open
hi-flyer opened this Issue May 17, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@hi-flyer

hi-flyer commented May 17, 2018

Expected behaviour

when I set a new date format in date picker and date picker for php, I expect to be able to set a date in the time sheet. This is not a big issue as I have workaround as shown in reproducible section

Actual behaviour

when I set the "Date format for the datepicker" in advanced to yy:mm:dd and "Date format of datepicker in PHP" to Y:m:d and try to change a date in the time sheet (or set a date other that today) in a new entry, I get an error message saying it is not the right date format.

Steps to reproduce

Go to Advanced tab in admin panel
set format in "Date format for the datepicker" to yy:mm:dd
set "Date format of datepicker in PHP" to Y:m:d
go to timesheet
add new entry
Change date to a previous date (not todays date which is automatically entered)
get the error message not a valid date format.

change
set format in "Date format for the datepicker" to "dd:mm:yy"
set "Date format of datepicker in PHP" to d:m:Y
timesheet works correctly.

Reproducable on demo.kimai.org? [yes|no]

did not try

Kimai version [for example: dev 1.1.0.1389|github master|github develop]

v1.2.2.1394 - © 2006-18 by the Kimai-Team:

Relevant log entries from log file (debug tab or temporary/logfile.txt)

log file from today when error occurred.
[17.05.2018 07:57:12] login: beckstein as user
[17.05.2018 07:57:32] KSPI axAction (beckstein): add_edit_timeSheetEntry
[17.05.2018 07:57:32] KSPI axAction (beckstein): reload_activities_options
[17.05.2018 07:57:32] KSPI axAction (beckstein): bestFittingRates
[17.05.2018 07:57:57] KSPI axAction (beckstein): add_edit_timeSheetEntry
[17.05.2018 07:57:57] timeEntry_create
[17.05.2018 07:57:57] KSPI axAction (beckstein): reload_timeSheet
[17.05.2018 07:59:12] KSPI axAction (beckstein): add_edit_timeSheetEntry
[17.05.2018 07:59:12] KSPI axAction (beckstein): reload_activities_options
[17.05.2018 07:59:12] KSPI axAction (beckstein): bestFittingRates
[17.05.2018 08:00:10] KSPI axAction (beckstein): add_edit_timeSheetEntry
[17.05.2018 08:00:11] KSPI axAction (beckstein): reload_activities_options
[17.05.2018 08:00:11] KSPI axAction (beckstein): bestFittingRates
[17.05.2018 08:00:29] KSPI axAction (beckstein): add_edit_timeSheetEntry
[17.05.2018 08:00:29] timeEntry_create
[17.05.2018 08:00:29] KSPI axAction (beckstein): reload_timeSheet
[17.05.2018 08:00:39] KSPI axAction (beckstein): add_edit_timeSheetEntry
[17.05.2018 08:00:39] KSPI axAction (beckstein): reload_activities_options
[17.05.2018 08:01:03] KSPI axAction (beckstein): refreshSubtab
[17.05.2018 08:01:03] KSPI axAction (beckstein): refreshSubtab
[17.05.2018 08:01:03] KSPI axAction (beckstein): refreshSubtab
[17.05.2018 08:01:36] KSPI axAction (beckstein): sendEditAdvanced
[17.05.2018 08:01:48] KSPI axAction (beckstein): add_edit_timeSheetEntry
[17.05.2018 08:01:48] KSPI axAction (beckstein): reload_activities_options
[17.05.2018 08:01:58] KSPI axAction (beckstein): add_edit_timeSheetEntry
[17.05.2018 08:01:58] timeEntry_edit: 417
[17.05.2018 08:01:58] KSPI axAction (beckstein): reload_timeSheet
[17.05.2018 08:02:37] KSPI axAction (beckstein): setTimeframe
[17.05.2018 08:02:37] KSPI axAction (beckstein): reload_timeSheet
[17.05.2018 08:05:45] KSPI axAction (beckstein): refreshSubtab
[17.05.2018 08:05:45] KSPI axAction (beckstein): refreshSubtab
[17.05.2018 08:05:45] KSPI axAction (beckstein): refreshSubtab
[17.05.2018 08:14:47] KSPI axAction (beckstein): credits
[17.05.2018 08:22:27] KSPI axAction (beckstein): refreshSubtab
[17.05.2018 08:22:27] KSPI axAction (beckstein): refreshSubtab
[17.05.2018 08:22:27] KSPI axAction (beckstein): refreshSubtab

@hi-flyer

This comment has been minimized.

hi-flyer commented May 17, 2018

note, in the formats above there is a : between each of the year month and day settings for the "Date format of datepicker in PHP". It appears differently on the web display. sorry about that.

@simonschaufi

This comment has been minimized.

Member

simonschaufi commented May 17, 2018

You can use markdown (backticks) to show proper text instead of emojies ;)

@herbertheaver

This comment has been minimized.

herbertheaver commented May 30, 2018

I want to echo my frustration with date configuration. I'm trying to configure Kimai to use standard ISO date formats (yyyy-mm-dd). However, this causes an error in the date picker, as it will properly show the ISO date, but then blow up with an error when I click OK.

Below: My configuration
kimai_01_date_config

Below: How an event appears. This is OK.
kimai_02_table

Below: When attempting to edit a date, picker shows existing date in d.m.yy format
kimai_03_edit_entry

Below: Picker inserts changed date in ISO format, which is the format specified in configuration
kimai_04_date_picker

Below: Edit fails with incorrect date format message.
kimai_05_error

@simonschaufi

This comment has been minimized.

Member

simonschaufi commented May 30, 2018

Please calm down. There is a pull request which should fix your issue: #1121 It would be great if you could help us do a review of this pull request! We are no company and kimai is free of charge. Kimai is completely done in our free time and community driven. Since you didn't even pay a single dollar for it, you shouldn't be frustrated. Help us by fixing it or support us financially!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment