New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing translation (hardcoded) #1203

Open
DJCrashdummy opened this Issue Jun 10, 2018 · 2 comments

Comments

Projects
None yet
1 participant
@DJCrashdummy
Contributor

DJCrashdummy commented Jun 10, 2018

Expected behaviour

after switching to german [de] everything should be in german.

i would have contributed the translation myself, but i didn't find a corresponding string neither at en.php nor at de.php and this message is also untranslated in a bunch of other languages... so i'm afraid this message may be hardcoded? - or are the extension-translations stored somewhere else?

Actual behaviour

a picture is worth a 1000 words:
export

Steps to reproduce

go to export-tab, mark at least one entry as cleared and then toggle the button in the table-header to unclear at least one entry.

Reproducible on demo.kimai.org? [yes|no]

yes

Kimai version [for example: dev 1.1.0.1389|github master|github develop]

v1.3.1.1394

Relevant log entries from log file (debug tab or temporary/logfile.txt)

@DJCrashdummy

This comment has been minimized.

Contributor

DJCrashdummy commented Jun 11, 2018

indeed it is hardcoded and also equipped with a comment:

// TODO: add translations somehow
if (!confirm('There are already ' + checked_elements + ' cleared entries!\nDo you really want to set these entries to uncleared?')) {

@DJCrashdummy

This comment has been minimized.

Contributor

DJCrashdummy commented Jun 11, 2018

btw: the message in this window does/can not distinguish between singular and plural (always uses the plural).

@DJCrashdummy DJCrashdummy changed the title from missing translation (maybe hardcoded) to missing translation (hardcoded) Jun 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment