Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PHP 8 #2158

Merged
merged 66 commits into from May 31, 2021
Merged

Support for PHP 8 #2158

merged 66 commits into from May 31, 2021

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented Dec 3, 2020

Description

LOOKING FOR HELP WITH TESTING!

TODO BC breaks

  • document necessary plugin updates
  • document requirement bump to PHP 7.3

FIXED

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst marked this pull request as draft December 3, 2020 11:33
@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #2158 (b221b48) into master (df6bd30) will decrease coverage by 0.11%.
The diff coverage is 84.21%.

❗ Current head b221b48 differs from pull request most recent head f510c36. Consider uploading reports for the commit f510c36 to get more accurate results

@@             Coverage Diff              @@
##             master    #2158      +/-   ##
============================================
- Coverage     92.79%   92.67%   -0.12%     
- Complexity     6738     6740       +2     
============================================
  Files           616      616              
  Lines         20135    20142       +7     
============================================
- Hits          18684    18667      -17     
- Misses         1451     1475      +24     
Impacted Files Coverage Δ
src/Controller/DoctorController.php 73.55% <78.57%> (-1.01%) ⬇️
...Transformer/DurationStringToSecondsTransformer.php 88.88% <100.00%> (ø)
src/Ldap/LdapUserProvider.php 94.28% <100.00%> (ø)
src/Repository/RolePermissionRepository.php 100.00% <100.00%> (ø)
src/Security/DoctrineUserProvider.php 94.44% <100.00%> (ø)
src/Utils/LocaleHelper.php 100.00% <100.00%> (ø)
...rc/Controller/Reporting/ReportByUserController.php 80.18% <0.00%> (-14.42%) ⬇️
src/Ldap/LdapDriver.php 65.30% <0.00%> (-10.21%) ⬇️

@kevinpapst kevinpapst changed the title Testing PHP 8 Support for PHP 8 Dec 17, 2020
# Conflicts:
#	.github/workflows/linting.yaml
#	composer.json
#	composer.lock
@kevinpapst kevinpapst added this to the 1.15 milestone May 31, 2021
@kevinpapst kevinpapst marked this pull request as ready for review May 31, 2021 12:29
@kevinpapst kevinpapst merged commit 4859ac8 into master May 31, 2021
@kevinpapst kevinpapst deleted the php8 branch May 31, 2021 12:53
kevinpapst added a commit that referenced this pull request Jul 13, 2021
painful 66 commits later: required PHP version bumped to 7.3, plugin updates using migrations necessary!
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

1 participant